Skip to content

Improvement: Fix conversation list state #625

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 21, 2025

Conversation

eylulnc
Copy link
Contributor

@eylulnc eylulnc commented May 21, 2025

Problem Description

On click to a channel and go back user go back to start of the list.

Changes

Store the list position and display list accordingly

Steps for testing

Open conversation enabled course
Scroll to a channel
Verify on click to channel and back return scroll state remain the same.

Screenshots

Screen.Recording.2025-05-21.at.15.09.40.mov

@eylulnc eylulnc requested a review from FelberMartin May 21, 2025 13:12
@eylulnc eylulnc self-assigned this May 21, 2025
@eylulnc eylulnc linked an issue May 21, 2025 that may be closed by this pull request
@eylulnc eylulnc added the ready for review This PR can be reviewed label May 21, 2025
Copy link
Collaborator

@FelberMartin FelberMartin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, works as expected!

@FelberMartin FelberMartin added ready to merge This PR can be merged and removed ready for review This PR can be reviewed labels May 21, 2025
@FelberMartin FelberMartin merged commit a452769 into develop May 21, 2025
5 checks passed
@FelberMartin FelberMartin deleted the improvement/communication/remmeber-scroll-state branch May 21, 2025 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge This PR can be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remember scroll state in conversations overview
2 participants