Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use INODESPEC and INODETYPE in test cases in tests dir #113

Open
masatake opened this issue Oct 3, 2020 · 0 comments
Open

use INODESPEC and INODETYPE in test cases in tests dir #113

masatake opened this issue Oct 3, 2020 · 0 comments

Comments

@masatake
Copy link
Contributor

masatake commented Oct 3, 2020

Item 1 and item 2 must be considered.

Thanks for the pointers I wasn't really familiar with the codebase but now I see the real issue was the test not using INODEPSPEC and INODETYPE (instead it used an unsigned int and %u). 

Going forward I think the fix is to replace
1. PRIu64 (used to be just _%u_ before my commit) --> INODEPSPEC "u" 
2. uint64_t (used to be just _unsigned int_ before my commit) --> INODETYPE
3. unsigned long long (for INODETYPE) --> uint64_t (**optional** based on your reply)
4. 'll' (for INODEPSPEC) --> PRIu64 (**optional** based on your reply)
    * For this reason I don't think we should change the optional bit since PRIu64 includes the "u" character and INODESPEC does not. If we changed it here we would need to change the other defs for it as well as main.c. IMO just the first 2 changes are good enough to fix the bug and keep the code consistent. 

Does this generally sound reasonable? Are you okay with me leaving the optional bit out for now?

Originally posted by @hvpeteet in #99 (comment)

@masatake masatake changed the title use INODESPEC and INODETYPE in test cases in tetss dir use INODESPEC and INODETYPE in test cases in tests dir Oct 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant