Skip to content

Commit 2a9c468

Browse files
authored
Merge pull request #231 from lsst-sqre/tickets/DM-46777/backport-sphinx-pin
DM-46777: sphinx < 8.1.0
2 parents 8d2bb24 + 6e23b31 commit 2a9c468

File tree

3 files changed

+10
-2
lines changed

3 files changed

+10
-2
lines changed
Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,4 @@
1+
### Bug fixes
2+
3+
- Pin `sphinx` to < 8.1.0. [Sphinx 8.1.0](https://github.com/sphinx-doc/sphinx/compare/v8.0.2...v8.1.0) contains [a commit](https://github.com/sphinx-doc/sphinx/pull/12762/files#diff-a4c6bf1492ef480b94af82c988f64ca56fa256fab0ed043a5ad3d4043f89a645L14) that removes the `ExtensionError` export from the `sphinx.util` package. This currently breaks the [sphinxcontrib-mermaid](https://github.com/mgaitan/sphinxcontrib-mermaid) dependency.
4+

pyproject.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ requires-python = ">=3.11"
2424
dynamic = ["version"]
2525
dependencies = [
2626
"docutils>=0.20", # solves an extra div bug with the bibliography directive
27-
"Sphinx>=7", # Consistent docutils constraint
27+
"Sphinx>=7,<8.1.0", # Consistent docutils constraint, mermaid compatibility
2828
"PyYAML",
2929
"GitPython",
3030
"requests",

src/documenteer/stackdocs/doxygen.py

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -333,7 +333,11 @@ def render(self) -> str:
333333
self._render_path_list(lines, tag_name, value)
334334
elif tag_field.type == List[str]:
335335
self._render_str_list(lines, tag_name, value)
336-
elif tag_field.type == Path or tag_field.type == Optional[Path]:
336+
elif (
337+
tag_field.type == Path
338+
or tag_field.type
339+
== Optional[Path] # type: ignore[comparison-overlap]
340+
):
337341
self._render_path(lines, tag_name, value)
338342
return "\n".join(lines) + "\n"
339343

0 commit comments

Comments
 (0)