From 2302676fae228f24a6cd18ba5a0ef9104a1122ce Mon Sep 17 00:00:00 2001 From: Krzysztof Findeisen Date: Tue, 28 Jan 2025 16:03:48 -0800 Subject: [PATCH] Remove DEBUG_CACHE_CALIBS flag from Prompt Processing. The flag was a workaround for another workaround for a bug in how calibs were loaded into local repos. Now that loading is done correctly, there's no need for the override. --- .../values-usdfdev-prompt-processing.yaml | 4 ---- .../values-usdfdev-prompt-processing.yaml | 4 ---- .../values-usdfdev-prompt-processing.yaml | 4 ---- charts/prompt-proto-service/README.md | 1 - .../prompt-proto-service/templates/prompt-proto-service.yaml | 2 -- charts/prompt-proto-service/values.yaml | 3 --- 6 files changed, 18 deletions(-) diff --git a/applications/prompt-proto-service-hsc/values-usdfdev-prompt-processing.yaml b/applications/prompt-proto-service-hsc/values-usdfdev-prompt-processing.yaml index 2280e37891..98c1d7d582 100644 --- a/applications/prompt-proto-service-hsc/values-usdfdev-prompt-processing.yaml +++ b/applications/prompt-proto-service-hsc/values-usdfdev-prompt-processing.yaml @@ -43,8 +43,4 @@ prompt-proto-service: endpointUrl: https://usdf-rsp-dev.slac.stanford.edu/sasquatch-rest-proxy auth_env: false - debug: - # A cache efficiency workaround breaks on RC2 tests; see DM-43205. - cacheCalibs: false - fullnameOverride: "prompt-proto-service-hsc" diff --git a/applications/prompt-proto-service-latiss/values-usdfdev-prompt-processing.yaml b/applications/prompt-proto-service-latiss/values-usdfdev-prompt-processing.yaml index b292d43c29..8c6d40bec6 100644 --- a/applications/prompt-proto-service-latiss/values-usdfdev-prompt-processing.yaml +++ b/applications/prompt-proto-service-latiss/values-usdfdev-prompt-processing.yaml @@ -44,8 +44,4 @@ prompt-proto-service: endpointUrl: https://usdf-rsp-dev.slac.stanford.edu/sasquatch-rest-proxy auth_env: false - debug: - # A cache efficiency workaround breaks when mixing observing dates; see DM-43205, DM-43913. - cacheCalibs: false - fullnameOverride: "prompt-proto-service-latiss" diff --git a/applications/prompt-proto-service-lsstcomcam/values-usdfdev-prompt-processing.yaml b/applications/prompt-proto-service-lsstcomcam/values-usdfdev-prompt-processing.yaml index 52e1ce3b4a..f02302990a 100644 --- a/applications/prompt-proto-service-lsstcomcam/values-usdfdev-prompt-processing.yaml +++ b/applications/prompt-proto-service-lsstcomcam/values-usdfdev-prompt-processing.yaml @@ -43,8 +43,4 @@ prompt-proto-service: endpointUrl: https://usdf-rsp-dev.slac.stanford.edu/sasquatch-rest-proxy auth_env: false - debug: - # A cache efficiency workaround breaks when mixing observing dates; see DM-43205, DM-43913. - cacheCalibs: false - fullnameOverride: "prompt-proto-service-lsstcomcam" diff --git a/charts/prompt-proto-service/README.md b/charts/prompt-proto-service/README.md index a5404b7896..b06266000c 100644 --- a/charts/prompt-proto-service/README.md +++ b/charts/prompt-proto-service/README.md @@ -22,7 +22,6 @@ Event-driven processing of camera images | cache.patchesPerImage | int | `4` | A factor by which to multiply `baseSize` for templates and other patch-based datasets. | | cache.refcatsPerImage | int | `4` | A factor by which to multiply `baseSize` for refcat datasets. | | containerConcurrency | int | `1` | The number of Knative requests that can be handled simultaneously by one container | -| debug.cacheCalibs | bool | `true` | Whether or not calibs should be cached between runs of a pod. This is a temporary flag that should only be unset in specific circumstances, and only in the development environment. | | debug.exportOutputs | bool | `true` | Whether or not pipeline outputs should be exported to the central repo. This flag does not turn off APDB writes or alert generation; those must be handled at the pipeline level or by setting up an alternative destination. | | fullnameOverride | string | `"prompt-proto-service"` | Override the full name for resources (includes the release name) | | image.pullPolicy | string | `IfNotPresent` in prod, `Always` in dev | Pull policy for the PP image | diff --git a/charts/prompt-proto-service/templates/prompt-proto-service.yaml b/charts/prompt-proto-service/templates/prompt-proto-service.yaml index 2a4cf0f0f7..18ad92bd60 100644 --- a/charts/prompt-proto-service/templates/prompt-proto-service.yaml +++ b/charts/prompt-proto-service/templates/prompt-proto-service.yaml @@ -123,8 +123,6 @@ spec: value: {{ .Values.cache.refcatsPerImage | toString | quote }} - name: PATCHES_PER_IMAGE value: {{ .Values.cache.patchesPerImage | toString | quote }} - - name: DEBUG_CACHE_CALIBS - value: {{ if .Values.debug.cacheCalibs }}'1'{{ else }}'0'{{ end }} - name: DEBUG_EXPORT_OUTPUTS value: {{ if .Values.debug.exportOutputs }}'1'{{ else }}'0'{{ end }} volumeMounts: diff --git a/charts/prompt-proto-service/values.yaml b/charts/prompt-proto-service/values.yaml index 1124fe1907..7f8227f4e1 100644 --- a/charts/prompt-proto-service/values.yaml +++ b/charts/prompt-proto-service/values.yaml @@ -173,9 +173,6 @@ fullnameOverride: "prompt-proto-service" containerConcurrency: 1 debug: - # -- Whether or not calibs should be cached between runs of a pod. - # This is a temporary flag that should only be unset in specific circumstances, and only in the development environment. - cacheCalibs: true # -- Whether or not pipeline outputs should be exported to the central repo. # This flag does not turn off APDB writes or alert generation; those must be handled at the pipeline level or by setting up an alternative destination. exportOutputs: true