From ec4d4491e54e396a854882fa3abb5115137600f5 Mon Sep 17 00:00:00 2001 From: Jake Kurlander Date: Thu, 5 Feb 2026 13:42:17 -0800 Subject: [PATCH 1/2] Change default values for SSObject per-band parameters Updated default values for Chi2 and nObsUsed for each band to use NaN and 0 respectively. --- python/lsst/pipe/tasks/ssp/ssobject.py | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/python/lsst/pipe/tasks/ssp/ssobject.py b/python/lsst/pipe/tasks/ssp/ssobject.py index a59ea2be9..a050e38e9 100644 --- a/python/lsst/pipe/tasks/ssp/ssobject.py +++ b/python/lsst/pipe/tasks/ssp/ssobject.py @@ -76,13 +76,15 @@ def compute_ssobject_entry(row, sss): df = sss[sss["dia_band"] == band] # set defaults for this band (equivalents of NULL) - row[f"{band}_Chi2"] = -1 + row[f"{band}_Chi2"] = np.nan row[f"{band}_G12"] = np.nan row[f"{band}_G12Err"] = np.nan row[f"{band}_H"] = np.nan row[f"{band}_H_{band}_G12_Cov"] = np.nan row[f"{band}_HErr"] = np.nan - row[f"{band}_nObsUsed"] = -1 + row[f"{band}_nObsUsed"] = 0 + row[f"{band}_phaseAngleMin"] = np.nan + row[f"{band}_phaseAngleMax"] = np.nan nBandObs = len(df) row[f"{band}_nObs"] = nBandObs From 6dcf3cb0f5044579de6fc22594ac686be2f09a98 Mon Sep 17 00:00:00 2001 From: Jake Kurlander Date: Thu, 5 Feb 2026 14:43:36 -0800 Subject: [PATCH 2/2] Use HG12 nDof = nObs - 2 --- python/lsst/pipe/tasks/ssp/ssobject.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/python/lsst/pipe/tasks/ssp/ssobject.py b/python/lsst/pipe/tasks/ssp/ssobject.py index a050e38e9..54fe7e2e5 100644 --- a/python/lsst/pipe/tasks/ssp/ssobject.py +++ b/python/lsst/pipe/tasks/ssp/ssobject.py @@ -99,7 +99,7 @@ def compute_ssobject_entry(row, sss): H, G12, sigmaH, sigmaG12, covHG12, chi2dof, nobsv = photfit.fitHG12( df["dia_psfMag"], df["dia_psfMagErr"], df["phaseAngle"], df["topoRange"], df["helioRange"] ) - nDof = 2 + nDof = nBandObs - 2 # print(provID, band, H, G12, sigmaH, sigmaG12, covHG12, # chi2dof, nobsv)