Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check for Hard Coding / Missing ArgParse Help / Scar Code #1

Open
lgcharpe opened this issue Apr 4, 2024 · 0 comments
Open

Check for Hard Coding / Missing ArgParse Help / Scar Code #1

lgcharpe opened this issue Apr 4, 2024 · 0 comments
Assignees
@davda54 @SondreWold @lgcharpe
Labels
documentation Improvements or additions to documentation

Comments

@lgcharpe
Copy link
Collaborator

lgcharpe commented Apr 4, 2024

The title pretty much sums it up but we might want to go through the code and remove scar code, hard coding and add helpful help for the argparse parameters.

For now, I looked at the Linear Probing and this is what I have seen:

  • Scar code in the UDPipe model (the linear things)
  • Missing help for the argparse parameters in the train file for linear probing.
@lgcharpe lgcharpe added the documentation Improvements or additions to documentation label Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@davda54 davda54

@SondreWold SondreWold

@lgcharpe lgcharpe

Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@davda54 @SondreWold @lgcharpe