Skip to content

Review the mechanism for passing along the reconstruction parameters #90

@lucabaldini

Description

@lucabaldini

It looks like we are repeating the parameter names in a lot of places, e.g.,

[lbaldini@pcpi0188 hexsample]$ grep  eta_3pix_rad0 -r src/
src/hexsample/clustering.py:    def eta(self, eta_2pix_rad: float, eta_3pix_rad0: float, eta_3pix_rad1: float,
src/hexsample/clustering.py:        eta_3pix_rad0 : float
src/hexsample/clustering.py:            dr = Probit().evaluate(eta_sum, eta_3pix_rad0, eta_3pix_rad1) * pitch
src/hexsample/recon.py:    eta_3pix_rad0: float
src/hexsample/recon.py:                     "eta_3pix_rad0": self.eta_3pix_rad0,
src/hexsample/pipeline.py:    eta_3pix_rad0 = kwargs.get("eta_3pix_rad0", defaults.eta_3pix_rad0)
src/hexsample/pipeline.py:           pos_recon_algorithm, eta_2pix_rad, eta_3pix_rad0, eta_3pix_rad1, eta_3pix_theta0, \
src/hexsample/cli.py:        group.add_argument("--eta_3pix_rad0",
src/hexsample/cli.py:                           default=tasks.ReconstructionDefaults.eta_3pix_rad0,
src/hexsample/tasks.py:    eta_3pix_rad0: float = 0.513
src/hexsample/tasks.py:        eta_3pix_rad0: float = ReconstructionDefaults.eta_3pix_rad0,
src/hexsample/tasks.py:                                     eta_2pix_rad, eta_3pix_rad0, eta_3pix_rad1,

This might indicate that there is a better way to do this.

(For one thing, ReconEvent shouldn't carry along the information of the parameters used, not Cluster should. Clustering might.)

We realized this bacause it makes very difficult to rename any of the parameters...

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions