New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Golint: Refactor config keys #6

Open

lucasgomide opened this issue Nov 22, 2017 · 0 comments

Owner

lucasgomide commented Nov 22, 2017

lint suggested

lucasgomide/snitch/hook/newrelic.go:16:2: struct field ApplicationId should be ApplicationID
lucasgomide/snitch/hook/newrelic.go:17:2: struct field ApiKey should be APIKey
lucasgomide/snitch/hook/slack.go:14:2: struct field WebhookUrl should be WebhookURL
lucasgomide/snitch/hook/slack_test.go:9:5: var webhookUrl should be webhookURL

In order to fix it, we need refactor func executeHook(h types.Hook, deploy []types.Deploy, conf interface{}) to don't use reflect

The text was updated successfully, but these errors were encountered:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment