Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't use md5 in the recipe roller code #5

Open
riannucci opened this issue May 19, 2016 · 0 comments
Open

Don't use md5 in the recipe roller code #5

riannucci opened this issue May 19, 2016 · 0 comments

Comments

@riannucci
Copy link
Member

It's kind of embarrassing. Though I can't think of any security related issues with it, so I don't think this is urgent.
chromium-infra-bot pushed a commit that referenced this issue Sep 8, 2016
@danjacques
Revert of Track step nesting in StreamEngine. (patchset #5 id:80001 of …
339eace 
…https://codereview.chromium.org/2245113002/ )

Reason for revert:
Broke a build: https://uberchromegw.corp.google.com/i/internal.infra.cron/builders/recipe-autoroller-internal/builds/18474/steps/build.roll/logs/candidate%20%233

Original issue's description:
> Track step nesting in StreamEngine.
>
> Currently, step nesting is tracked by the step runner as an integer,
> which is passed to the stream engine as the `set_nest_level` post-create
> event. This poses two problems, namely:
> - The nest level is known to the runner immediately on step creation,
>   but is presented to the stream engine as a separate piece of
>   information.
> - This forces the step runner's concept of nesting (integer) onto the
>   stream engine, when all it really cares about is whether or not a step
>   is nested.
>
> This patch updates the API to pass the nested state as a boolean: either
> a step is nested in the previous step, or it isn't. The stream engine is
> responsible for tracking how it represents this to the stream's
> consumer. The nested state is also passed at step creation, making
> nesting an atomic step propety instead of an out-of-band option.
>
> Along the way, small cleanups.
>
> BUG=chromium:628770
> TEST=local
>   - Ran unit tests locally.
>   - `./recipes.py --package ./infra/config/recipes.cfg run example/nested`
>
> Committed: 4b3ff60

TBR=martiniss@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=chromium:628770

Review-Url: https://codereview.chromium.org/2320223002
chromium-infra-bot pushed a commit that referenced this issue Feb 25, 2017
@martiniss
Revert of remote: support non-hash revisions (patchset #5 id:80001 of h…
3f78fe8 
…ttps://codereview.chromium.org/2701193002/ )

Reason for revert:
Broke all the bots

Original issue's description:
> remote: support non-hash revisions
>
> Add support for gerrit change ref a revision.
>
> Document assumptions
>
> R=iannucci@chromium.org, phajdan.jr@chromium.org
> BUG=662654
>
> Review-Url: https://codereview.chromium.org/2701193002
> Committed: 41d8068

TBR=iannucci@chromium.org,phajdan.jr@chromium.org,nodir@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=662654

Review-Url: https://codereview.chromium.org/2719663002
chromium-infra-bot pushed a commit that referenced this issue Mar 8, 2017
@riannucci
Revert of [package.proto] add canonical_base_url field. (patchset #5 …
28c10d4 
…id:80001 of https://chromiumcodereview.appspot.com/2728303004/ )

Reason for revert:
aand kitchen needs to handle this proto. reverting.

Original issue's description:
> [package.proto] add canonical_base_url field.
>
> Also document the fields in package.proto and re-run protoc.
>
> canonical_base_url will be used when generating new Markdown documentation
> to allow for meaningful hyperlinks. It's also generally a good idea so when
> packages get mirrored, they'll always point to the source of truth.
>
> NOTE: This changes the tag values for the proto definition... however, since
> we've never used the binary form of the package message, it shouldn't be a
> problem. This allows canonical base url to sort above 'deps'. Otherwise it gets
> sorted to the bottom of the file, which is weird.
>
> R=dnj@chromium.org, martiniss@chromium.org, phajdan.jr@chromium.org
> BUG=
>
> Review-Url: https://codereview.chromium.org/2728303004
> Committed: 22e413a

TBR=martiniss@chromium.org,dnj@chromium.org,phajdan.jr@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=

Review-Url: https://codereview.chromium.org/2739803002
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@riannucci