Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion: clarify if emitDecoratorMetadata is required or not in docs #1443

Closed
2 of 4 tasks
aldenquimby opened this issue Jun 23, 2023 · 3 comments
Closed
2 of 4 tasks

Comments

@aldenquimby
Copy link
Contributor

Sorting

  • I'm submitting a ...

    • bug report
    • feature request
    • support request
  • I confirm that I

    • used the search to make sure that a similar issue hasn't already been submit

Expected Behavior

Current Behavior

  • It's unclear to me. My app appears to work fine with this turned off, but I also see relfect-metadata used in this repo
  • Is it required to use custom middleware, but otherwise not needed?

Possible Solution

  • Clarify why "emitDecoratorMetadata": true is part of the suggested "imported" tsconfig
  • If it is needed for some part of tsoa to work, consider breaking that out into an optional/separate package (eg @tsoa/middleware)

Steps to Reproduce

  • N/A

Context (Environment)

Version of the library: 5.x
Version of NodeJS: 18

  • Confirm you were using yarn not npm: [x]

Detailed Description

  • N/A

Breaking change?

  • N/A
@WoH
Copy link
Collaborator

WoH commented Jun 24, 2023

It should only be needed for middlewares, yes

@aldenquimby
Copy link
Contributor Author

@WoH great, thank you! Here's a partial fix that is a start: tsoa-community/docs#77

@aldenquimby
Copy link
Contributor Author

@WoH here is the follow up that I think can close this suggestion out: tsoa-community/docs#78

@WoH WoH closed this as completed Jun 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants