Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent setting not allowed response headers #1658

Open
2 tasks
maxuai opened this issue Aug 2, 2024 · 5 comments
Open
2 tasks

Prevent setting not allowed response headers #1658

maxuai opened this issue Aug 2, 2024 · 5 comments

Comments

@maxuai
Copy link

maxuai commented Aug 2, 2024

Sorting

  • I'm submitting a ...

    • bug report
    • [ x ] feature request
    • support request
  • I confirm that I

    • [ x ] used the search to make sure that a similar issue hasn't already been submit

Expected Behavior

Trying to set a not allowed value for response headers via @Header throws an error.

Current Behavior

Setting a not allowed value for response headers e.g @Header('Accept') acceptHeader: 'application/json', will be included in the generated OpenAPI file.

Copy link

github-actions bot commented Aug 2, 2024

Hello there maxuai 👋

Thank you for opening your very first issue in this project.

We will try to get back to you as soon as we can.👀

@maxuai
Copy link
Author

maxuai commented Aug 2, 2024

As I just realized: This value is use for validation which of course won't work anymore when not set. So maybe it should be allowed to set it but not included in the generated OpenAPI spec file?

Copy link

github-actions bot commented Sep 2, 2024

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days

@github-actions github-actions bot added the Stale label Sep 2, 2024
@maxuai
Copy link
Author

maxuai commented Sep 2, 2024

do not close

@github-actions github-actions bot removed the Stale label Sep 3, 2024
Copy link

github-actions bot commented Oct 3, 2024

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants