Added support for Inline images for SmtpSender #276
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I had this issue also. I was already fixing the branch until I saw this pull request. Please add an unit test @austinpn |
Author
|
There is not really a good way to test this without parsing the email on the other end, or exposing |
|
@austinpn I added some tests to a new pull request i created. I am not very expirienced with the github way of contributing, so forgive for not adding it to your PR (if possible)) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed System.Net.Mime.ContentDisposition.Inline to match Core.Models.Attachment.IsInline.
Attachment's Content-Disposition header will be set to "inline" instead of "attachment" when attachment is marked inline, allowing it to be referenced by content-id when using SmtpSender.