Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide a translation layer for incompatible set abbreviations. (Mostly affects promotional cards) #2

Open
luziferius opened this issue Dec 22, 2019 · 0 comments
Labels
bug Something isn't working enhancement New feature or request

Comments

@luziferius
Copy link
Owner

It seems that many platforms use their own convention for promotional cards or card sets.

When translating decks, the promotional sets have to be translated as well, as the target application may not understand the set abbreviations of the source application.

For example, TappedOut uses "000" for special promotional printings: http://tappedout.net/mtg-set/promo-set/, whilst Scryfall has a set for each individual promotional printing.

TappedOut set list: http://tappedout.net/magic-cards/
Scryfall set list: https://scryfall.com/sets

To solve this, some kind of translation layer is required.

Some promotional sets can be translated between TappedOut and Scryfall 1:1, as both sites have the same set, which only differs in the set abbreviation.

But the TappedOut "000" set needs some special handling.
A giant lookup table will solve this, but will be brittle as it has to be maintained manually.
If possible, a dynamic solution should be created for this case.

@luziferius luziferius changed the title Provide a translation layer for incompatible set abbreviations. Provide a translation layer for incompatible set abbreviations. (Mostly affects promotional cards) Dec 22, 2019
@luziferius luziferius added bug Something isn't working enhancement New feature or request labels Dec 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant