Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XMage: Prerelease Promo cards #3

Open
luziferius opened this issue Jan 2, 2020 · 0 comments
Open

XMage: Prerelease Promo cards #3

luziferius opened this issue Jan 2, 2020 · 0 comments

Comments

@luziferius
Copy link
Owner

Stamped cards given as a Prerelease event promo are grouped in the PTC pseudo-set in XMage. See the source code here: https://github.com/magefree/mage/blob/master/Mage.Sets/src/mage/sets/PrereleaseEvents.java

TappedOut CSV exports contain this information in the Foil column by indicating the foiling to be pre.

To Support Prerelease promos:

  • Update the Card data class. Instead of a foil boolean, use a speciality enumeration.
    @dataclass
    class Card:
    """This is a single MTG card"""
    english_name: str = None
    set_abbreviation: str = None
    # Most cards have integer collector numbers, but some require further disambiguation in the form of appended letters
    # To support collector numbers like "86a", the collector number is handled as a string.
    collector_number: str = None
    # Returned by TappedOut.
    language: str = "EN"
    foil: bool = False
    condition: str = None
  • Update the CSV parser to set the card speciality instead of the foil boolean.
  • Include a translation layer in the XMage exporter that looks at the card and replaces the set abbreviation with PTC if the card is a Prerelease promo.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant