Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Query parameter in GetRepositoryPullRequestsAsync misnamed #30

Open
ghost opened this issue Oct 8, 2023 · 0 comments
Open

Query parameter in GetRepositoryPullRequestsAsync misnamed #30

ghost opened this issue Oct 8, 2023 · 0 comments

Comments

@ghost
Copy link

ghost commented Oct 8, 2023

First of all: Many thanks for this project! It was very helpful for me ❤️

I came across a small issue in line 37 of BitbucketCloudClient.cs: The query parameter should be named state instead of q to match the description of the API method:

public async Task<IEnumerable<PullRequest>> GetRepositoryPullRequestsAsync(string workspaceId, string repositorySlug, int? maxPages = null, string state = null)
{
    var queryParamValues = new Dictionary<string, object>
    {
        [nameof(state)] = state
    };
    ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

0 participants