Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convenience methods should check if keys are correct size #14

Open
lvh opened this issue Oct 1, 2016 · 0 comments
Open

Convenience methods should check if keys are correct size #14

lvh opened this issue Oct 1, 2016 · 0 comments

Comments

@lvh
Copy link
Owner

lvh commented Oct 1, 2016

Right now, if you pass a key that is too short, encryption will appear to work, but part of your key will be whatever garbage happened to be in memory.

If you pass a key that is too long, it will silently ignore the rest of the key. This might be a "feature" someone is relying on though, and is less obviously wrong than the former.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant