Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pwhash should raise on error, not fail silently #35

Open
lvh opened this issue Jan 18, 2018 · 0 comments
Open

pwhash should raise on error, not fail silently #35

lvh opened this issue Jan 18, 2018 · 0 comments

Comments

@lvh
Copy link
Owner

lvh commented Jan 18, 2018

Many pwhash functions can fail for all sorts of reasons, including:

  • using unacceptable parameters (e.g. number of operations lower than OPSLIMIT_MIN). this changed between 1.0.14 and 1.0.15 so this is not an unrealistic scenario!
  • failure to malloc sufficient RAM

Other functions, like signature verification functions, raise on failure. pwhash functions should too.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@lvh