Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide imediately and delay settings #34

Open
khabib227 opened this issue Aug 12, 2023 · 3 comments
Open

Hide imediately and delay settings #34

khabib227 opened this issue Aug 12, 2023 · 3 comments

Comments

@khabib227
Copy link

First thanks for this plugin. Currently the plugin just hide the element when you stop scrolling and also has a delay a fade effect, please add a option to hide imediately, before you start scrolling, and a settings to choose the delays to hide and show for instance when hovering over, to remove all delays and fade effects.

@lykahb
Copy link
Owner

lykahb commented Aug 18, 2023

I think that it is reasonable to disable delays and animation. I would welcome a PR.

The request about scrolling is harder to meet - many websites would look broken with parts of the layout missing - header or even the whole viewport. Sticky ducky first priority is not to break the sites. Hiding the stickies is only second. I tried using the variations of heuristics with different ratio of risk/effectiveness. The current one is optimal.

I also wish that there were a general way to hide chat widgets or cookie consent, but hiding them immediately breaks other things. Anything more aggressive than the current heuristics that would be better to apply only per-site. I'd recommend using one of the cosmetic lists for uBlock Origin or just zapping the elements with it.

@khabib227
Copy link
Author

khabib227 commented Aug 18, 2023

I would add the disable delays and animation PR, but I'm not a programmer, I have no knowledge. About hide stickies when start scrolling, you have reason, this really can break some sites, is better keep as currently when we stop scrolling.

@khabib227
Copy link
Author

khabib227 commented Aug 18, 2023

You can also add a Agressive Mode per site, currently we have a Whitelist, so you can add a new Agressive Mode List, so if the user want a more aggressive algorithm can just click in a button on plugin panel or use keyboard shortcut, this can be very useful because many sites need a more aggressive algorithm, youtube is one, and use ublock for it is not a good alternative because the user sometimes don't want hide the stickies forever, and hide manually every time you use youtube is a pain.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants