Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add div around headline & body text (excluding image) #305

Open
ashyablok opened this issue Aug 8, 2018 · 3 comments
Open

Add div around headline & body text (excluding image) #305

ashyablok opened this issue Aug 8, 2018 · 3 comments
Assignees

Comments

@ashyablok
Copy link
Contributor

Currently, pathfora does not have a wrapper div around the headline text and the main content of the modal, that does not include the image. To allow for proper image floats (without setting a width on the image) we'd want a div that could be flexible:

For example:

screen shot 2018-08-08 at 10 45 56 am

This looks ok, but when we try to do this with a smaller content space the image is constrained to just the text and button space, and with a width set, it looks odd.
screen shot 2018-08-08 at 10 46 15 am

@kristinh12 kristinh12 self-assigned this Nov 5, 2018
@kristinh12
Copy link
Contributor

@sarahyablok should we add this for both modals and slideouts?

@ashyablok
Copy link
Contributor Author

@kristinh12 I would guess all module types.

@kristinh12
Copy link
Contributor

#317

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants