Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to delete detail_override properties #633

Open
inghamemerson opened this issue Nov 3, 2023 · 2 comments
Open

Unable to delete detail_override properties #633

inghamemerson opened this issue Nov 3, 2023 · 2 comments
Assignees

Comments

@inghamemerson
Copy link
Contributor

inghamemerson commented Nov 3, 2023

Hello, per the docs I made updates to an experience, stipulating some custom callbacks in detail_override. But when trying to remove the overrides, they persist. It appears the changes are not being merged or cleaned up as one might expect. I tried, without success, the following methods to nullify the overrides:

  1. Removing the payload in the UI and save
  2. Sending a PATCH request with the properties removed to https://api.lytics.io/api/experience/{experience_id}
{
  "experience": {
    "vehicle": {
      "detail_override": {
      }
    }
}
  1. Sending a PATCH request with some sort of falsey value to https://api.lytics.io/api/experience/{experience_id}:
{
  "experience": {
    "vehicle": {
      "detail_override": {
        "confirmAction": null | false | {} | ""
      }
    }
}

The third method results in the property taking the value, ie a GET request shows "confirmAction": null, "confirmAction": "" or "confirmAction": {} while attempting false the request is rejected, but causing errors as one might expect in the actual experience when clicking the CTA since the confirmAction is being overridden by something useless.

Ultimately we had to create a new experience from scratch to resolve the issue.

Is there a proper way to clean out overrides that I'm missing? I'm more than happy to open this in the repo that handles the requests and updates if it's public, or open a PR if I can be pointed in the right direction.

Thank you so much!

@ashyablok
Copy link
Contributor

@inghamemerson Thank you for filing this. Likely this will require a fix in our APIs and not the Pathfora SDK itself. I will be working on a backend fix and will keep you update on this ticket as things progress.

@ashyablok ashyablok self-assigned this Nov 7, 2023
@inghamemerson
Copy link
Contributor Author

inghamemerson commented Nov 7, 2023

Thanks @ashyablok. Happy to move this elsewhere if more appropriate, but I assume the fix is in private code.

I appreciate you getting back to me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants