-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stampede Stage Requires Charm Check #171
Comments
Added DB Cleanup flag because we can go back and update the stage for hunts to better match the reality - "No Stampede" unless it is both a Stampede AND has the correct charm armed. |
Bonus points if we want to add the Grubling Bonanza charm which increases AR of a grubling. |
I believe the check is correct as-is. If we only set the "Stampede" stage when there is both a stampede and the chow charm armed, then we cannot deduce population differences between "grublings are stampeding" and "grublings are not stampeding" In other words, I feel it is reasonable that there may be 3 distinct populations:
|
I think we have a couple ways we can bring this forward. Three stages as suggested there is one of them. Another is two stages of Grublings (third stage)/No Grublings (stages one and two) but with stampede status as a hunt_detail. The first allows for the most people to break down the ARs and DRs into the three stages, of which two might be identical - but this isn't really a problem. The second allows the two stages to be investigated in case there are differences but would require SQL. I vote for the three stage method. |
sounds good:
|
mh-helper-extension/src/scripts/main.js
Line 1492 in 45565c0
Currently the only change in stage that can happen is if the Grubling Chow Charm is also armed. So we'll need to add that as a check.
The text was updated successfully, but these errors were encountered: