Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stampede Stage Requires Charm Check #171

Open
AardWolf opened this issue Jun 16, 2022 · 5 comments
Open

Stampede Stage Requires Charm Check #171

AardWolf opened this issue Jun 16, 2022 · 5 comments
Labels
bug Something isn't working good first issue Good for newcomers hacktoberfest Good option for Hacktoberfest contributors Needs DB Cleanup

Comments

@AardWolf
Copy link
Contributor

message.stage = (user.quests.QuestSandDunes.minigame.has_stampede) ? "Stampede" : "No Stampede";

Currently the only change in stage that can happen is if the Grubling Chow Charm is also armed. So we'll need to add that as a check.

@AardWolf AardWolf added bug Something isn't working Needs DB Cleanup labels Jun 16, 2022
@AardWolf
Copy link
Contributor Author

Added DB Cleanup flag because we can go back and update the stage for hunts to better match the reality - "No Stampede" unless it is both a Stampede AND has the correct charm armed.

@AardWolf
Copy link
Contributor Author

Bonus points if we want to add the Grubling Bonanza charm which increases AR of a grubling.

@tehhowch
Copy link
Contributor

I believe the check is correct as-is. If we only set the "Stampede" stage when there is both a stampede and the chow charm armed, then we cannot deduce population differences between "grublings are stampeding" and "grublings are not stampeding"

In other words, I feel it is reasonable that there may be 3 distinct populations:

  1. No Stampede
  2. Stampede
  3. Stampede w/Chow Charm armed

@AardWolf
Copy link
Contributor Author

I think we have a couple ways we can bring this forward. Three stages as suggested there is one of them. Another is two stages of Grublings (third stage)/No Grublings (stages one and two) but with stampede status as a hunt_detail.

The first allows for the most people to break down the ARs and DRs into the three stages, of which two might be identical - but this isn't really a problem. The second allows the two stages to be investigated in case there are differences but would require SQL.

I vote for the three stage method.

@logicalup
Copy link
Contributor

sounds good:

  1. no stampede
  2. stampede without chow
  3. stampede with chow

@AardWolf AardWolf added the hacktoberfest Good option for Hacktoberfest contributors label Sep 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers hacktoberfest Good option for Hacktoberfest contributors Needs DB Cleanup
Projects
None yet
Development

No branches or pull requests

3 participants