Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modularize this anonymous function #215

Open
AardWolf opened this issue Oct 13, 2022 · 2 comments
Open

Modularize this anonymous function #215

AardWolf opened this issue Oct 13, 2022 · 2 comments
Labels
good first issue Good for newcomers hacktoberfest Good option for Hacktoberfest contributors Medium Priority

Comments

@AardWolf
Copy link
Contributor

journal_entries.forEach(markup => {

If we pull out this functionality into its own function we can more easily test the logic of the function with automated testing -- or from the console.

@AardWolf AardWolf added good first issue Good for newcomers Medium Priority hacktoberfest Good option for Hacktoberfest contributors labels Oct 13, 2022
@SyndicateGit
Copy link

SyndicateGit commented Aug 22, 2024

Hi, I'm new to mh-helper but I have experience working with chrome extension before. If this ticket is still relevant I'd like to take a crack at it.

Edit: To clarify, did you want to modularize the entire journal_enteries markup handling (pass journal_enteries as param) or individual markup (pass markup as param)? I'd feel like markup would be easier to test and read with journal_enteries.forEach( markup => handleJournalEnteriesMarkup(markup);

@hymccord
Copy link
Contributor

The whole thing needs to be modularized but the loop would be a great point to start with something small. Similar to the ajax handlers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers hacktoberfest Good option for Hacktoberfest contributors Medium Priority
Projects
None yet
Development

No branches or pull requests

3 participants