Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically exclude OAM and other MLab IPs #44

Open
mattmathis opened this issue Aug 7, 2019 · 3 comments
Open

Automatically exclude OAM and other MLab IPs #44

mattmathis opened this issue Aug 7, 2019 · 3 comments
Assignees
Labels

Comments

@mattmathis
Copy link
Contributor

The list of excluded IPs need to be managed more dynamically than a source file.

Is a union over all time the right answer?
Is a union across prod and staging the right answer?

(This is a long term solution to #6)

@autolabel autolabel bot added the review/triage Team should review and assign priority label Aug 7, 2019
@pboothe pboothe self-assigned this Sep 9, 2019
@pboothe pboothe added the backlog label Sep 9, 2019
@autolabel autolabel bot removed the review/triage Team should review and assign priority label Sep 9, 2019
@pboothe
Copy link
Contributor

pboothe commented Sep 9, 2019

Matt, could you say more here?

@mattmathis mattmathis linked a pull request Mar 11, 2021 that will close this issue
@mattmathis mattmathis removed a link to a pull request Mar 12, 2021
@mattmathis
Copy link
Contributor Author

I see three plausible interim solutions:

  1. add a primitive macro expansion to create_dataset_views.sh to update IaOAM in 6 places.
  2. Keep an OAM list in a table in a temporary location (accessed by the extended views). Temporarily manage the list in the same scope as the the views themselves (e.g. by create_dataset_views.sh)
  3. Create an OAM list in a TBD permanent location. where it can be managed by k8s. Also an interim method to update it.

My preference would be 2, which has the least stranded engineering cost, and would be a huge step towards 3. Only the table location needs to change.

@mattmathis
Copy link
Contributor Author

We can also automatically detect tests run from IP addresses similar tt our clusters, to help seed a manually curated OAM list, It can be updated retroactively.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants