Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

httpx has log.Fatalf calls that are not clearly documented. #32

Open
gfr10598 opened this issue Feb 28, 2019 · 0 comments
Open

httpx has log.Fatalf calls that are not clearly documented. #32

gfr10598 opened this issue Feb 28, 2019 · 0 comments

Comments

@gfr10598
Copy link
Contributor

ListenAndServe*Async both may call log.Fatalf, which is buried down under the server shutdown. Though we don't expect to be shutting down servers, it is still worrisome that a server shutdown may crash the whole process, and is very hard to see when calling the top level functions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant