Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flagx datatypes are initialized differently from native types #42

Open
pboothe opened this issue Mar 28, 2019 · 1 comment
Open

Flagx datatypes are initialized differently from native types #42

pboothe opened this issue Mar 28, 2019 · 1 comment
Labels

Comments

@pboothe
Copy link
Contributor

pboothe commented Mar 28, 2019

Do we want to unify them, so code would look like:

  datatypes := flagx.StringArray("datatype", "Help text")

instead of the two-stage init that they currently require?

@pboothe
Copy link
Contributor Author

pboothe commented Apr 8, 2019

The right solution is to define the datatypes in their own package (like bytecount is) but to create the methods flagx.ByteCount and flagx.ByteCountVar in the flagx package. This means that we need to create those methods for bytecount, and we need to move FileBytes to a filebytes package and then create those two methods for it as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant