-
-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ffprobe cache #26
Comments
Hmm, it should not do again. Is the cache file there? |
I tried it, got |
I'm using cache inside the vod tag, Should I put this cache outsite? |
Correct. Found some issue, when cache does not contain keyframes (if selected) when accesssing master playlist. |
The ffprobe now is starting from the master and each profile. Before ffprobe was only started from the profile. |
They should share the same cache. But I think, the problem is race condition. When master profile starts ffprobe, it takes some time. If some profile starts in meanwhile, it does not see cache entry and starts again. It does not know, that other ffprobe is in progress, since every profile has its own manager started. |
sorry, now that I made a mistake, the cache is working now |
Ok, but when I set the cache is true, the generator doesn't use the ffprobe keyframe |
Another problem is, that when the cache exists, even without keyframes, it does not generate them. I think that should be fixed too. So if you have valid cache without keyframes, it won't generate them additionally. |
When the cache is true, can we save the ffprobe stream result? Every request to the same file with different resolution (maybe the same too), the ffprobe is running again.
The text was updated successfully, but these errors were encountered: