Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inefficient Animation rendering #23

Open
suryadheeshjith opened this issue Feb 13, 2024 · 7 comments
Open

Inefficient Animation rendering #23

suryadheeshjith opened this issue Feb 13, 2024 · 7 comments
Assignees

Comments

@suryadheeshjith
Copy link
Collaborator

Possible inefficiencies due to matplotlib - cartopy and create_animation() function.

See OM4_SE_animation.ipynb Link to notebook and here.

@suryadheeshjith
Copy link
Collaborator Author

The initial implementation provided by the helper functions manually saves each frame as a PNG file, then reads them back into a PIL Image list to create a GIF.

@IamShubhamGupto
Copy link
Member

Did some investigating today and even after caching variables, I got a build time exceeding 10 minutes.

a reference to what we did in the l96 demo - https://m2lines.github.io/L96_demo/notebooks/intro_ML_and_NNs.html?highlight=animation

@jbusecke
Copy link
Collaborator

Just came across this on X, might be relevant to the animation issue

@IamShubhamGupto
Copy link
Member

@suryadheeshjith can we close this?

@suryadheeshjith
Copy link
Collaborator Author

I need to explore more options for rendering before we close this issue!

@suryadheeshjith
Copy link
Collaborator Author

I tried using matplotlib.use("Agg") and it didn't help too much with or without saving temporary images. I also tried using hvplot but plotting a similar animation is much more involved. It would probably be best to keep what we have now and create a new notebook for these newer libraries.

@jbusecke
Copy link
Collaborator

I would suggest to keep this issue open since the root problem is not yet addressed and it might affect multiple notebooks. I do not think it is a top priority (we could use labels to indicate priority levels), but closing this indicates that the problem has been solved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants