-
Notifications
You must be signed in to change notification settings - Fork 1
/
manual-bind-to-arrow.js
184 lines (165 loc) · 5.28 KB
/
manual-bind-to-arrow.js
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
/**
* Copyright 2015-present, Facebook, Inc.
*
* This source code is licensed under the MIT license found in the
* LICENSE file in the root directory of this source tree.
*
*/
/**
* class Component extends React.Component {
* constructor() { this.onClick = this.onClick.bind(this); }
* onClick() { }
* }
*
* -->
*
* class Component extends React.Component {
* onClick = () => { }
* }
*/
export default function transformer(file, api, options) {
const j = api.jscodeshift;
const doesNotUseArguments = require('./doesNotUseArguments')(j);
const printOptions = options.printOptions || {};
var root = j(file.source);
// Helper functions to transform a method declaration to an arrow function
// By default recast drops comments and jscodeshift doesn't have a way to
// set the return type in the convenience method. Otherwise we would have
// inlined all those.
function withComments(to, from) {
to.comments = from.comments;
return to;
}
function createArrowFunctionExpression(fn) {
var arrowFunc = j.arrowFunctionExpression(fn.params, fn.body, false);
arrowFunc.returnType = fn.returnType;
arrowFunc.defaults = fn.defaults;
arrowFunc.rest = fn.rest;
arrowFunc.async = fn.async;
return arrowFunc;
}
function createArrowProperty(prop) {
return withComments(
j.classProperty(
j.identifier(prop.key.name),
createArrowFunctionExpression(prop.value),
null,
false
),
prop
);
}
var hasChanged = false;
var transform = root.find(j.AssignmentExpression).forEach(path => {
// Check that the englobing function is constructor
var methodPath = path;
while (
methodPath &&
(methodPath.node.type !== 'MethodDefinition' ||
methodPath.node.kind !== 'constructor')
) {
methodPath = methodPath.parentPath;
}
if (!methodPath) {
return;
}
// Check that it looks like
// this.method = this.method.bind(this);
// or
// (this: any).method = this.method.bind(this);
// or
// self.method = this.method.bind(this);
if (
!(
path.node.left.type === 'MemberExpression' &&
// this
(path.node.left.object.type === 'ThisExpression' ||
// self
(path.node.left.object.type === 'Identifier' &&
path.node.left.object.name === 'self') ||
// (this: any)
(path.node.left.object.type === 'TypeCastExpression' &&
path.node.left.object.expression.type === 'ThisExpression')) &&
path.node.left.property.type === 'Identifier' &&
path.node.right.type === 'CallExpression' &&
path.node.right.callee.type === 'MemberExpression' &&
path.node.right.callee.property.type === 'Identifier' &&
path.node.right.callee.property.name === 'bind' &&
path.node.right.callee.object.type === 'MemberExpression' &&
path.node.right.callee.object.property.type === 'Identifier' &&
path.node.right.callee.object.object.type === 'ThisExpression' &&
path.node.left.property.name ===
path.node.right.callee.object.property.name &&
true
)
) {
return;
}
// Find the method() declaration and replace it with an arrow function
var methodName = path.node.left.property.name;
const componentDecl = methodPath.parentPath;
var methods = j(componentDecl)
.find(j.MethodDefinition)
.filter(
path =>
path.node.key.type === 'Identifier' &&
path.node.key.name === methodName &&
doesNotUseArguments(path, file.path)
);
// Do not remove the binding if there's no corresponding method to turn
// into an arrow function, or if the method uses `arguments` keyword inside
// it.
if (methods.size() === 0) {
return;
}
methods.replaceWith(path => createArrowProperty(path.node));
// Remove the line
// this.method = this.method.bind(this);
j(path.parentPath).remove();
var selfCount = j(methodPath)
.find(j.Identifier, { name: 'self' })
.size();
if (selfCount === 1) {
// Remove the line
// const self: any = this;
// If self is present somewhere else in the method, then it is
// not safe to do.
j(methodPath)
.find(j.VariableDeclaration)
.filter(
path =>
j(path)
.find(j.Identifier, { name: 'self' })
.size() === 1
)
.remove();
}
// If we delete everything from the constructor but the super() call,
// then delete the entire constructor.
var canDeleteConstructor = true;
methodPath.node.value.body.body.forEach(node => {
if (
!node ||
(node.type === 'ExpressionStatement' &&
node.expression.type === 'CallExpression' &&
// babylon parser
(node.expression.callee.type === 'Super' ||
// flow parser
(node.expression.callee.type === 'Identifier' &&
node.expression.callee.name === 'super')))
) {
return;
}
canDeleteConstructor = false;
});
if (canDeleteConstructor) {
j(methodPath).remove();
}
hasChanged++;
});
if (hasChanged) {
return transform.toSource(printOptions);
}
return null;
}
// module.exports.parser = 'flow';