From 5396db3124e69736a156b88daaf4d6cb9df0f30c Mon Sep 17 00:00:00 2001 From: Cain Rinkoski <141179073+cainrinkMac@users.noreply.github.com> Date: Wed, 30 Aug 2023 19:12:22 +0000 Subject: [PATCH 1/4] Working on Issue #21 --- pyscope/reduction/calib_images.py | 3 +++ 1 file changed, 3 insertions(+) diff --git a/pyscope/reduction/calib_images.py b/pyscope/reduction/calib_images.py index 84ddd6ba..300681a6 100644 --- a/pyscope/reduction/calib_images.py +++ b/pyscope/reduction/calib_images.py @@ -11,6 +11,9 @@ from ..observatory import AstrometryNetWCS from .ccd_calib import ccd_calib +## Note to open pull request: Cain and Viet working on #21 + + logger = logging.getLogger(__name__) From 78190bbe70849d4f4399447e9213c07db28c8cb3 Mon Sep 17 00:00:00 2001 From: Cain Rinkoski <141179073+cainrinkMac@users.noreply.github.com> Date: Wed, 4 Oct 2023 23:35:01 +0000 Subject: [PATCH 2/4] Adding gh to codespace --- .devcontainer/devcontainer.json | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/.devcontainer/devcontainer.json b/.devcontainer/devcontainer.json index ee0ebaef..b308c3ab 100644 --- a/.devcontainer/devcontainer.json +++ b/.devcontainer/devcontainer.json @@ -32,5 +32,9 @@ } } } - } + + }, + "features": { + "ghcr.io/devcontainers/features/github-cli:1": {} + } } From f6340295e0a4349e59a1512ac67a3034a7c54258 Mon Sep 17 00:00:00 2001 From: Cain Rinkoski <141179073+cainrinkMac@users.noreply.github.com> Date: Thu, 5 Oct 2023 00:24:41 +0000 Subject: [PATCH 3/4] remove preexec_fn if on linux --- pyscope/observatory/simulator_server.py | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/pyscope/observatory/simulator_server.py b/pyscope/observatory/simulator_server.py index 86cf3fcf..16c4e66d 100644 --- a/pyscope/observatory/simulator_server.py +++ b/pyscope/observatory/simulator_server.py @@ -60,6 +60,14 @@ def __init__(self): stdout=subprocess.DEVNULL, shell=True, ) + elif platform.system() == "Linux": + self.process = subprocess.Popen( + ("sudo " + dirname + "/ascom.alpaca.simulators"), + start_new_session=True, + stderr=subprocess.DEVNULL, + stdout=subprocess.DEVNULL, + shell=True, + ) else: self.process = subprocess.Popen( (dirname + "/ascom.alpaca.simulators"), From 7a90551bffd31e8b9a7358d5bad47f7fadcc459f Mon Sep 17 00:00:00 2001 From: Cain Rinkoski <141179073+cainrinkMac@users.noreply.github.com> Date: Thu, 16 Nov 2023 16:24:06 +0000 Subject: [PATCH 4/4] undo change from closed pull request #46 --- pyscope/reduction/calib_images.py | 2 -- 1 file changed, 2 deletions(-) diff --git a/pyscope/reduction/calib_images.py b/pyscope/reduction/calib_images.py index 300681a6..daa737f2 100644 --- a/pyscope/reduction/calib_images.py +++ b/pyscope/reduction/calib_images.py @@ -11,8 +11,6 @@ from ..observatory import AstrometryNetWCS from .ccd_calib import ccd_calib -## Note to open pull request: Cain and Viet working on #21 - logger = logging.getLogger(__name__)