Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Notable breaks onSave of other Markdown extensions #11

Open
frudolph77 opened this issue Feb 17, 2022 · 0 comments
Open

[BUG] Notable breaks onSave of other Markdown extensions #11

frudolph77 opened this issue Feb 17, 2022 · 0 comments

Comments

@frudolph77
Copy link
Contributor

frudolph77 commented Feb 17, 2022

Hey,

I've found an other bug.

Having Notable and Markdown All in One installed, the onSave hooks wont run anymore, e.g. the updating of a TOC.
I first thought it's an issue with Markdown All in One, but it isn't see yzhang-gh/vscode-markdown#1079 (comment)

Comparing both onSave hooks shows a slight difference. I change the onSave of Notable to the way of Markdown All in One and now they work together.

I'll push these change to #10 my local branch was somehow broken. I'll file a new PR.

kind regards
Frank

@frudolph77 frudolph77 mentioned this issue Feb 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant