diff --git a/Exareme-Docker/src/exareme/exareme-master/src/main/java/madgik/exareme/master/gateway/async/handler/HBP/HBPQueryConstants.java b/Exareme-Docker/src/exareme/exareme-master/src/main/java/madgik/exareme/master/gateway/async/handler/HBP/HBPQueryConstants.java index 3cc35e154..9e9516b03 100644 --- a/Exareme-Docker/src/exareme/exareme-master/src/main/java/madgik/exareme/master/gateway/async/handler/HBP/HBPQueryConstants.java +++ b/Exareme-Docker/src/exareme/exareme-master/src/main/java/madgik/exareme/master/gateway/async/handler/HBP/HBPQueryConstants.java @@ -5,7 +5,11 @@ public class HBPQueryConstants { public static String pathologyNotProvided = "Please provide a pathology."; public static String datasetXDoesNotExistInPathologyY = "Dataset(s) %s does not exist in pathology %s."; - public static String datasetsXYZAreInactive = "The following datasets %s are currently unavailable. Please try again later."; + public static String datasetsXYZAreInactive = + "The following datasets %s are currently unavailable. Please try again later."; public static String nodesUnavailable = "Some nodes are unavailable. Please try again later."; + + public static String serverErrorOccurred = + "Something went wrong. Please consult the system administrator or try again later."; } diff --git a/Exareme-Docker/src/exareme/exareme-master/src/main/java/madgik/exareme/master/gateway/async/handler/HBP/HBPQueryHandler.java b/Exareme-Docker/src/exareme/exareme-master/src/main/java/madgik/exareme/master/gateway/async/handler/HBP/HBPQueryHandler.java index 1d884f1ca..bbc7c6b95 100644 --- a/Exareme-Docker/src/exareme/exareme-master/src/main/java/madgik/exareme/master/gateway/async/handler/HBP/HBPQueryHandler.java +++ b/Exareme-Docker/src/exareme/exareme-master/src/main/java/madgik/exareme/master/gateway/async/handler/HBP/HBPQueryHandler.java @@ -35,6 +35,7 @@ import java.util.Map; import static madgik.exareme.master.gateway.GatewayConstants.COOKIE_ALGORITHM_EXECUTION_ID; +import static madgik.exareme.master.gateway.async.handler.HBP.HBPQueryConstants.serverErrorOccurred; public class HBPQueryHandler implements HttpAsyncRequestHandler { @@ -176,18 +177,18 @@ private void handleHBPAlgorithmExecution(HttpRequest request, HttpResponse respo response.setStatusCode(HttpStatus.SC_BAD_REQUEST); response.setEntity(createErrorResponseEntity(e.getMessage(), errorType)); - } catch (JsonSyntaxException e) { - log.error("Could not parse the algorithms properly."); - String errorType = HBPQueryHelper.ErrorResponse.ErrorResponseTypes.error; - response.setStatusCode(HttpStatus.SC_BAD_REQUEST); - response.setEntity(createErrorResponseEntity("Could not parse the algorithms properly.", errorType)); - } catch (UserException e) { log.error(e.getMessage()); String errorType = HBPQueryHelper.ErrorResponse.ErrorResponseTypes.user_error; response.setStatusCode(HttpStatus.SC_BAD_REQUEST); response.setEntity(createErrorResponseEntity(e.getMessage(), errorType)); + } catch (JsonSyntaxException e) { + log.error("Could not parse the algorithms properly."); + String errorType = HBPQueryHelper.ErrorResponse.ErrorResponseTypes.error; + response.setStatusCode(HttpStatus.SC_BAD_REQUEST); + response.setEntity(createErrorResponseEntity(serverErrorOccurred, errorType)); + } catch (Exception e) { log.error(e.getMessage()); for (StackTraceElement stack : e.getStackTrace()) { @@ -197,7 +198,7 @@ private void handleHBPAlgorithmExecution(HttpRequest request, HttpResponse respo log.error(e.getStackTrace()); String errorType = HBPQueryHelper.ErrorResponse.ErrorResponseTypes.error; response.setStatusCode(HttpStatus.SC_BAD_REQUEST); - response.setEntity(createErrorResponseEntity(e.getMessage(), errorType)); + response.setEntity(createErrorResponseEntity(serverErrorOccurred, errorType)); } }