MTLBuffer contents pointer is nullable

[K0bin]

objc2_metal:

        /// Returns the data pointer of this buffer's shared copy.
        #[unsafe(method(contents))]
        #[unsafe(method_family = none)]
        fn contents(&self) -> NonNull<c_void>;

Apple documentation:

A pointer to the shared copy of the buffer data, or NULL for buffers allocated with a private resource storage mode (MTLStorageModePrivate).

[madsmtm]

Damn. This is a bug in Apple's headers (the header is marked NS_ASSUME_NONNULL_BEGIN, so contents should have been opted out with some sort of __nullable). Swift is actually also affected by this, they map the pointer as UnsafeMutableRawPointer instead of UnsafeMutableRawPointer?.

It's unfortunately a breaking change for me to properly fix, and while you can sometimes argue that it's fine when it's done to fix soundness issues, this isn't really a soundness issue for consumers unless they use MTLStorageModePrivate.

I'll probably fix for now by checking internally on access whether the pointer is NULL.

[madsmtm]

Hmm, actually, I know that's what the docs say, but how are you observing this?

The small test below seems to indicate that the docs for contents are actually incorrect?

use objc2_metal::{MTLBuffer, MTLCreateSystemDefaultDevice, MTLDevice, MTLResourceOptions};

#[link(name = "CoreGraphics", kind = "framework")]
extern "C" {}

fn main() {
    let device = MTLCreateSystemDefaultDevice().unwrap();
    let buffer = device.newBufferWithLength_options(100, MTLResourceOptions::StorageModePrivate).unwrap();
    println!("{:?}", buffer.contents());
}