Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User 2to3.py in anacoda can translate this project #12

Open
HardyChina opened this issue Dec 4, 2019 · 3 comments
Open

User 2to3.py in anacoda can translate this project #12

HardyChina opened this issue Dec 4, 2019 · 3 comments

Comments

@HardyChina
Copy link

Hi maechler,
thanks for your code,I reproduce Kelly‘s result by 2to3.py in anacoda can translate this project and kelly's porject. In fact, that is a feasible way that use the tool to runing on python 3.x,

@maechler
Copy link
Owner

maechler commented Dec 4, 2019

Hi @HardyChina,
Thanks for sharing! If you would like to create a pull request out of this I would be happy to include this into the project. Although I would probably create a separate branch for the Python 3 version.

@HardyChina
Copy link
Author

No problem

@maechler
Copy link
Owner

maechler commented Dec 6, 2019

@HardyChina It would probably make more sense to create a pull request for Jack Kelly's neuralnilm code in its own repository: https://github.com/JackKelly/neuralnilm

Instead of adding it to nnilm here https://github.com/HardyChina/nnilm/tree/master/neuralnilm. I also just saw that Jack Kelly made some changes to the code, probably to make it compatible with Python 3:
JackKelly/neuralnilm@95c529e

Maybe it would be enough to update nnilm to be compatible with Python 3 and update its dependencies here:

nnilm/requirements.txt

Lines 79 to 81 in 39f1382

-e git+https://github.com/JackKelly/neuralnilm/@c0539416ddcdffc27e89fb393f31cdc0f437d50a#egg=NeuralNILM
-e git+https://github.com/nilmtk/nilm_metadata/@c7348dd1fdb2a7a7f9aa1f808ff5d67bf39f97c6#egg=nilm_metadata
-e git+https://github.com/nilmtk/nilmtk/@e5cc77e560d2520861a7ce3aec1f6feda4441c9e#egg=nilmtk

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants