Creating flag to force dns server start even when in test mode #480 (#539)

* creating flag to forcec dns server start even when in test mode

* testing

Author: mageddo

src/main/java/com/mageddo/dnsproxyserver/server/Starter.java

@@ -9,7 +9,6 @@
 
 import javax.inject.Inject;
 import javax.inject.Singleton;
-
 import java.util.Set;
 
 import static com.mageddo.dnsproxyserver.quarkus.Quarkus.isTest;
@@ -19,21 +18,44 @@
 @RequiredArgsConstructor(onConstructor = @__({@Inject}))
 public class Starter {
 
+  public static final String DNS_SERVER_MUST_START_FLAG = "mg.server.server.must-start";
   private final ServerStarter dnsServerStarter;
   private final WebServer webServer;
   private final Set<StartupEvent> startupEvents;
 
   public void start() {
-    if(isTest()){
-      log.warn("status=onTest, disabled=[dnsServer, startupEvents]");
+    if (isTest()) {
+      log.warn("status=onTest, disabled=[startupEvents]");
     } else {
       this.startupEvents.forEach(StartupEvent::onStart);
-      this.dnsServerStarter.start();
     }
+    if (shouldStartDnsServer()) {
+      this.startDnsServer();
+    }
+    this.startWebServer();
+  }
+
+  void startWebServer() {
     this.webServer.start(Configs.getInstance().getWebServerPort());
   }
 
-  public void stop(){
+  void startDnsServer() {
+    this.dnsServerStarter.start();
+  }
+
+  private static boolean shouldStartDnsServer() {
+    return !isTest() || isMustStartFlagActive();
+  }
+
+  private static boolean isMustStartFlagActive() {
+    return Boolean.getBoolean(DNS_SERVER_MUST_START_FLAG);
+  }
+
+  public static void setMustStartFlagActive(boolean b) {
+    System.setProperty(DNS_SERVER_MUST_START_FLAG, String.valueOf(b));
+  }
+
+  public void stop() {
     this.dnsServerStarter.stop();
     this.webServer.stop();
   }

src/test/java/com/mageddo/dnsproxyserver/server/StarterTest.java

@@ -0,0 +1,47 @@
+package com.mageddo.dnsproxyserver.server;
+
+import org.junit.jupiter.api.Test;
+import org.junit.jupiter.api.extension.ExtendWith;
+import org.mockito.junit.jupiter.MockitoExtension;
+
+import java.util.Set;
+
+import static org.mockito.Mockito.doNothing;
+import static org.mockito.Mockito.never;
+import static org.mockito.Mockito.spy;
+import static org.mockito.Mockito.verify;
+
+@ExtendWith(MockitoExtension.class)
+class StarterTest {
+
+  final Starter starter = spy(new Starter(null, null, Set.of()));
+
+  @Test
+  void wontStartInTestMode() {
+
+    doNothing().when(this.starter).startWebServer();
+    doNothing().when(this.starter).startDnsServer();
+
+    this.starter.start();
+
+    verify(this.starter, never()).startDnsServer();
+    verify(this.starter).startWebServer();
+  }
+
+
+  @Test
+  void mustStartWhenInTestModeAndFlagForced() {
+
+    Starter.setMustStartFlagActive(true);
+
+    doNothing().when(this.starter).startWebServer();
+    doNothing().when(this.starter).startDnsServer();
+
+    this.starter.start();
+
+    verify(this.starter).startDnsServer();
+    verify(this.starter).startWebServer();
+
+    Starter.setMustStartFlagActive(false);
+  }
+}