From 41b9c95be96d4d01ff7d65ad570c2b03a9a20ed5 Mon Sep 17 00:00:00 2001 From: xenohedron Date: Wed, 8 Jan 2025 22:47:01 -0500 Subject: [PATCH] less intrusive error handling for #12833 --- .../org/mage/plugins/card/images/DownloadPicturesService.java | 4 ++-- .../main/java/org/mage/plugins/card/utils/CardImageUtils.java | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/Mage.Client/src/main/java/org/mage/plugins/card/images/DownloadPicturesService.java b/Mage.Client/src/main/java/org/mage/plugins/card/images/DownloadPicturesService.java index a6622c16c62a..1bb365f6b96d 100644 --- a/Mage.Client/src/main/java/org/mage/plugins/card/images/DownloadPicturesService.java +++ b/Mage.Client/src/main/java/org/mage/plugins/card/images/DownloadPicturesService.java @@ -725,8 +725,8 @@ public void run() { try { TVFS.umount(); } catch (FsSyncException e) { - logger.fatal("Couldn't unmount zip files " + e, e); - MageFrame.getInstance().showErrorDialog("Couldn't unmount zip files " + e, e); + logger.error("Couldn't unmount zip files " + e, e); + // this is not a critical error - just need to run it again - see issue #12833 } } diff --git a/Mage.Client/src/main/java/org/mage/plugins/card/utils/CardImageUtils.java b/Mage.Client/src/main/java/org/mage/plugins/card/utils/CardImageUtils.java index 3ded259a4665..1598840389ad 100644 --- a/Mage.Client/src/main/java/org/mage/plugins/card/utils/CardImageUtils.java +++ b/Mage.Client/src/main/java/org/mage/plugins/card/utils/CardImageUtils.java @@ -185,7 +185,7 @@ public static void checkAndFixImageFiles() { try { TVFS.umount(); } catch (FsSyncException e) { - LOGGER.fatal("Couldn't unmount zip files on searching broken images " + e, e); + LOGGER.error("Couldn't unmount zip files on searching broken images " + e, e); } // real images check is slow, so it used on images download only (not here)