Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DSK] Implement Nowhere to Run #13208

Merged
merged 5 commits into from
Jan 9, 2025
Merged

[DSK] Implement Nowhere to Run #13208

merged 5 commits into from
Jan 9, 2025
+235 −0

Conversation

markort147
Copy link
Contributor

Part of #12534

@markort147
Copy link
Contributor Author

I'm sorry, but in the applies method of NowhereToRunHexproofEffect class, I forgot to check if the permanent is a creature.
Please, wait untill I'll fix and test that.

@markort147 markort147 marked this pull request as draft January 8, 2025 05:35
@Grath
Copy link
Contributor

Grath commented Jan 9, 2025

No worries. Should just be a matter of adding && creature.isCreature(game) in the applies.

@markort147 markort147 marked this pull request as ready for review January 9, 2025 19:26
@Grath Grath self-requested a review January 9, 2025 19:29
Grath
Grath approved these changes Jan 9, 2025
View reviewed changes
Copy link
Contributor

@Grath Grath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, will merge once tests pass.

@Grath Grath merged commit 30dac5c into magefree:master Jan 9, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Grath Grath Grath approved these changes

Assignees
No one assigned
Labels
cards tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@markort147 @Grath