Use Author.Plugin instead of hardcoded plugin version

[LukeTowers]

October_Envbar/Plugin.php

Line 36 in 61f3421

$controller->addCss($this->settings->getPublicCssPath(), '1.0.2');

You can use Author.Plugin as the second argument to addAsset() which will automatically use the latest version number of the provided plugin. (@bennothommo could you add that to the docs? I don't think we have that behavior documented anywhere that references the System\Traits\AssetMaker)

[magenizr]

Hi @LukeTowers

Thank you for your input! Removing the version number, unfortunately, doesn't automatically add the latest version number because PluginVersion::getVersion($build) in getAssetEntryBuildPath always returns null.

We will provide an update as soon as we know why it returns null.

[LukeTowers]

@magenizr check your system_plugin_versions table, if your plugin changed the case or exact contents of its identifier then that would be why, since it uses the records in PluginVersion model to get the latest version, not the PluginManager which normalizes the input into a standard ID first

[magenizr]

@LukeTowers

Sorry, I believe the morning coffee didn't kick in when I read your comment. You're absolutely right, one of the following arguments automatically returns the plugin version.

$controller->addCss($this->settings->getPublicCssPath(), ['build' => 'Magenizr.Envbar']);
$controller->addCss($this->settings->getPublicCssPath(), 'Magenizr.Envbar');

https://github.com/octobercms/october/blob/9082a231a6030dc3191ff86088cd624922a3e345/modules/system/traits/AssetMaker.php#L315