Height property for search field

[lilvinco]

Hi there,

Great package, a great time saver.

It's quite frustrating though that the search field's height can not be customised. Would be nice to be able to constrain the height of the textfield at will, a possible way to go about it is wrapping the textfield with a SizeBox and exposing the height property.

[maheshj01]

Hi @lilvinco, Thanks for filing the issue. That sounds like a nice feature request. Also, I see you submitted a PR that seems to be closed. In case you want to contribute feel free to, I would love to review if not I can definitely get that landed in a week.

[lilvinco]

Thanks for the feedback, I will now create a new PR

[maheshj01]

Hi @lilvinco, Thanks for the PR. I was wondering of the usecase, where would we need to customize the height of the SearchField? since SearchField is always a singleliner. Even if you need this feature why not just wrap SearchField in SizedBox directly, wouldn't that work?

SizedBox(
  child: SearchField()
)

[lilvinco]

Hi @maheshmnj

Without the height feature, the search field takes a default height that wouldn't fit into every design. Also, wrapping the widget with a Sizebox doesn't reduce the searchfield's height, it only reduces the available space and so the result would be an overflow error or a clipped search field

[lilvinco]

[lilvinco]

1: searchableHeight : 50 is set
2. No height
3. Wrapped with SizedBox and set height property of 50

[maheshj01]

@lilvinco Just checking with you, if you would be interested in working on this any time soon?

[lilvinco]

Oh yeah @maheshmnj

I had worked on it but my PR was left unattended to for a long time

[maheshj01]

Apologies for the delay @lilvinco, Now I am actively working on this package.

[lilvinco]

Alright, I'll review it again

[lilvinco]

Hi @maheshmnj ,
I created a new PR here #135

[maheshj01]

@lilvinco thanks for the PR it looks great, And I really appreciate the time and effort you put in to get the PR, But I think that change is not required now, There have been significant changes in Searchfield since this issue was filed and now Searchfield should respect Its parent constraints without this PR. You can directly wrap a searchfield with a SizedBox or a Container and it should work out of the box. Let me know if that doesn't work for you.

If you encounter any other issues or have suggestions to improve this package, You are more than Welcome!

Thank you again for your effort.