Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

/subscribers is using cursor pagination #20

Open
igaster opened this issue Dec 27, 2023 · 1 comment
Open

/subscribers is using cursor pagination #20

igaster opened this issue Dec 27, 2023 · 1 comment

Comments

@igaster
Copy link

igaster commented Dec 27, 2023

This method is expecting a page parameter, but the API is using cursor pagination (See https://github.com/mailerlite/mailerlite/pull/10128)

Also our docs: https://developers.mailerlite.com/docs/subscribers.html#list-all-subscribers

We should update method to expect with a cursor instead

This could break existing implementations. Maybe we need a new major version

@igaster
Copy link
Author

igaster commented Dec 27, 2023

@nklmilojevic it looks like a simple fix, but I don't have write permission to this repo... Anyway you would be the reviewer :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant