Merge pull request #41 from exaring/do_not_consider_canceled_context_as_peer_error

thrawn01 · web-flow · commit 87609ae02ec8 · 2022-05-23T11:55:35.000-05:00
feat: do not count context cancelation as peer error
diff --git a/groupcache.go b/groupcache.go
@@ -386,6 +386,9 @@ func (g *Group) load(ctx context.Context, key string, dest Sink) (value ByteView
 			if err == nil {
 				g.Stats.PeerLoads.Add(1)
 				return value, nil
+			} else if errors.Is(err, context.Canceled) {
+				// do not count context cancellation as a peer error
+				return nil, err
 			}
 
 			if logger != nil {

Original file line number	Diff line number	Diff line change
`@@ -386,6 +386,9 @@ func (g *Group) load(ctx context.Context, key string, dest Sink) (value ByteView`
`386`	`386`	`if err == nil {`
`387`	`387`	`g.Stats.PeerLoads.Add(1)`
`388`	`388`	`return value, nil`
	`389`	`+ } else if errors.Is(err, context.Canceled) {`
	`390`	`+ // do not count context cancellation as a peer error`
	`391`	`+ return nil, err`
`389`	`392`	`}`
`390`	`393`
`391`	`394`	`if logger != nil {`