refactor: remove magic numbers

Signed-off-by: Stefan Dej <meteyou@gmail.com>
mainsail-crew · May 26, 2024 · 0f14149 · 0f14149
1 parent 97fc98a
commit 0f14149
Showing 1 changed file with 5 additions and 2 deletions.
diff --git a/src/store/printer/getters.ts b/src/store/printer/getters.ts
@@ -144,10 +144,13 @@ export const getters: GetterTree<PrinterState, RootState> = {
         const settings = state.configfile?.settings ?? null
         const printerGcodes = state.gcode?.commands ?? {}
 
+        const prefix = 'gcode_macro '
+        const prefixLength = prefix.length
+
         Object.keys(state)
-            .filter((prop) => prop.toLowerCase().startsWith('gcode_macro '))
+            .filter((prop) => prop.toLowerCase().startsWith(prefix))
             .forEach((prop) => {
-                const name = prop.slice(12)
+                const name = prop.slice(prefixLength)
                 const printerGcode = printerGcodes[name.toUpperCase()] ?? {}
 
                 // remove macros with a '_' as first char