From 8a349ea3bd6f7c25992ee6f2b6669f8bf68f13ea Mon Sep 17 00:00:00 2001
From: Stefan Dej <meteyou@gmail.com>
Date: Wed, 28 Jun 2023 23:23:14 +0200
Subject: [PATCH] refactor: fix FarmPrinterPanel.vue

Signed-off-by: Stefan Dej <meteyou@gmail.com>
---
 src/components/panels/FarmPrinterPanel.vue | 49 +++++++++++++---------
 src/store/farm/printer/actions.ts          | 13 +++---
 src/store/farm/printer/getters.ts          | 10 +----
 src/store/farm/printer/index.ts            |  2 +-
 src/store/farm/printer/types.ts            |  4 +-
 5 files changed, 37 insertions(+), 41 deletions(-)

diff --git a/src/components/panels/FarmPrinterPanel.vue b/src/components/panels/FarmPrinterPanel.vue
index 6d5222052..377782f9e 100644
--- a/src/components/panels/FarmPrinterPanel.vue
+++ b/src/components/panels/FarmPrinterPanel.vue
@@ -2,10 +2,8 @@
     <panel
         :icon="mdiPrinter3d"
         :title="printer_name"
-        :card-class="
-            'farmprinter-panel ' +
-            (!printer.socket.isConnected && !printer.socket.isConnecting ? 'disabledPrinter' : '')
-        "
+        card-class="farmprinter-panel"
+        :class="panelClass"
         :loading="printer.socket.isConnecting"
         :toolbar-color="isCurrentPrinter ? 'primary' : ''">
         <template #buttons>
@@ -17,7 +15,7 @@
                     </v-btn>
                 </template>
                 <v-list dense class="py-0">
-                    <v-list-item link @click="currentCamId = 'off'">
+                    <v-list-item link @click="currentCamName = 'off'">
                         <v-list-item-icon class="mr-2">
                             <v-icon small class="mt-1">{{ mdiWebcamOff }}</v-icon>
                         </v-list-item-icon>
@@ -27,9 +25,9 @@
                     </v-list-item>
                     <v-list-item
                         v-for="webcam of printer_webcams"
-                        :key="webcam.index"
+                        :key="webcam.name"
                         link
-                        @click="currentCamId = webcam.id">
+                        @click="currentCamName = webcam.name">
                         <v-list-item-icon class="mr-2">
                             <v-icon small class="mt-1">{{ convertWebcamIcon(webcam.icon) }}</v-icon>
                         </v-list-item-icon>
@@ -47,7 +45,7 @@
                         <div
                             v-if="
                                 printer.socket.isConnected &&
-                                currentCamId !== 'off' &&
+                                currentCamName !== 'off' &&
                                 currentWebcam &&
                                 'service' in currentWebcam
                             "
@@ -122,6 +120,7 @@ import { mdiPrinter3d, mdiWebcam, mdiMenuDown, mdiWebcamOff, mdiFileOutline } fr
 import { Debounce } from 'vue-debounce-decorator'
 import WebcamMixin from '@/components/mixins/webcam'
 import WebcamWrapper from '@/components/webcams/WebcamWrapper.vue'
+import { GuiWebcamStateWebcam } from '@/store/gui/webcams/types'
 
 @Component({
     components: {
@@ -156,12 +155,12 @@ export default class FarmPrinterPanel extends Mixins(BaseMixin, WebcamMixin) {
         return this.$store.getters['farm/' + this.printer._namespace + '/isCurrentPrinter']
     }
 
-    get currentCamId() {
-        return this.$store.getters['farm/' + this.printer._namespace + '/getSetting']('currentCamId', 'off')
+    get currentCamName() {
+        return this.$store.getters['farm/' + this.printer._namespace + '/getSetting']('currentCamName', 'off')
     }
 
-    set currentCamId(newVal) {
-        this.$store.dispatch('farm/' + this.printer._namespace + '/setSettings', { currentCamId: newVal })
+    set currentCamName(newVal) {
+        this.$store.dispatch('farm/' + this.printer._namespace + '/setSettings', { currentCamName: newVal })
     }
 
     get printer_name() {
@@ -199,18 +198,30 @@ export default class FarmPrinterPanel extends Mixins(BaseMixin, WebcamMixin) {
     }
 
     get showWebcamSwitch() {
-        return this.printer.socket.isConnected && this.printer_webcams.length > 0
+        if (this.printer_webcams.length == 0) return false
+
+        return this.printer.socket.isConnected
     }
 
-    get printer_webcams() {
+    get printer_webcams(): GuiWebcamStateWebcam[] {
         return this.$store.getters['farm/' + this.printer._namespace + '/getPrinterWebcams']
     }
 
-    get currentWebcam() {
-        const currentCam = this.printer_webcams.find((webcam: any) => webcam.id === this.currentCamId)
+    get currentWebcam(): GuiWebcamStateWebcam | null {
+        const currentCam = this.printer_webcams?.find(
+            (webcam: GuiWebcamStateWebcam) => webcam.name === this.currentCamName
+        )
         if (currentCam) return currentCam
 
-        return false
+        return null
+    }
+
+    get panelClass(): string[] {
+        let output = []
+
+        if (!this.printer.socket.isConnected && !this.printer.socket.isConnecting) output.push('disabledPrinter')
+
+        return output
     }
 
     clickPrinter() {
@@ -268,10 +279,8 @@ export default class FarmPrinterPanel extends Mixins(BaseMixin, WebcamMixin) {
 .v-overlay {
     top: 48px;
 }
-</style>
 
-<style>
-.farmprinter-panel {
+::v-deep .farmprinter-panel {
     position: relative;
 }
 </style>
diff --git a/src/store/farm/printer/actions.ts b/src/store/farm/printer/actions.ts
index ceb1dbb91..b3da5a260 100644
--- a/src/store/farm/printer/actions.ts
+++ b/src/store/farm/printer/actions.ts
@@ -230,13 +230,10 @@ export const actions: ActionTree<FarmPrinterState, RootState> = {
             })
         }
 
-        if (payload.namespaces.includes('webcams')) {
-            dispatch('sendObj', {
-                method: 'server.database.get_item',
-                params: { namespace: 'webcams' },
-                action: 'getWebcamsData',
-            })
-        }
+        dispatch('sendObj', {
+            method: 'server.webcams.list',
+            action: 'getWebcamsData',
+        })
     },
 
     getMainsailData({ commit }, payload) {
@@ -244,6 +241,6 @@ export const actions: ActionTree<FarmPrinterState, RootState> = {
     },
 
     getWebcamsData({ commit }, payload) {
-        commit('setWebcamsData', payload.value)
+        commit('setWebcamsData', payload.webcams)
     },
 }
diff --git a/src/store/farm/printer/getters.ts b/src/store/farm/printer/getters.ts
index 29c7ce651..45b0022a8 100644
--- a/src/store/farm/printer/getters.ts
+++ b/src/store/farm/printer/getters.ts
@@ -308,14 +308,6 @@ export const getters: GetterTree<FarmPrinterState, any> = {
     },
 
     getPrinterWebcams: (state) => {
-        const webcams: GuiWebcamStateWebcam[] = []
-
-        /*if (state.data.webcams) {
-            Object.keys(state.data.webcams).forEach((id: string) => {
-                webcams.push({ ...state.data?.webcams[id], id })
-            })
-        }*/
-
-        return webcams
+        return state.data.webcams.filter((webcam: GuiWebcamStateWebcam) => webcam.enabled)
     },
 }
diff --git a/src/store/farm/printer/index.ts b/src/store/farm/printer/index.ts
index e7d5bc7d1..0245165ad 100644
--- a/src/store/farm/printer/index.ts
+++ b/src/store/farm/printer/index.ts
@@ -26,7 +26,7 @@ export const getDefaultState = (): FarmPrinterState => {
         },
         data: {
             gui: getGuiDefaultState(),
-            webcams: {},
+            webcams: [],
         },
         settings: {},
         databases: [],
diff --git a/src/store/farm/printer/types.ts b/src/store/farm/printer/types.ts
index 653392475..e1cd33d19 100644
--- a/src/store/farm/printer/types.ts
+++ b/src/store/farm/printer/types.ts
@@ -8,9 +8,7 @@ export interface FarmPrinterState {
     server: FarmPrinterStateServer
     data: {
         gui: GuiState
-        webcams: {
-            [key: string]: GuiWebcamStateWebcam
-        }
+        webcams: GuiWebcamStateWebcam[]
         // eslint-disable-next-line
         [key: string]: any
     }