Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Theme Switch #1297

Closed
Steven2k6 opened this issue Mar 6, 2023 · 6 comments · Fixed by #1580
Closed

Theme Switch #1297

Steven2k6 opened this issue Mar 6, 2023 · 6 comments · Fixed by #1580
Labels
good first issue Simple task for new contributors 💡 Type: FR Requests a new feature
Milestone

Comments

@Steven2k6
Copy link

Requested feature:

A switch to change the Theme from dark to Light and backwards.

I made a Vuetify3 Project as example.

code

Maybe you can also add a setting to set the colors for the Dark and Light Theme.
I uploaded a zip with the Vue-File.
Switch-Test.zip

Solves the following problem:

No response

Additional information:

No response

@Steven2k6 Steven2k6 added the 💡 Type: FR Requests a new feature label Mar 6, 2023
@meteyou
Copy link
Member

meteyou commented Mar 6, 2023

Feel free to made a PR, but there are some parts, which also needs some other css settings, because only switching to light mode doesn't fit.

@Steven2k6
Copy link
Author

I don't know if its possible, because I'm relativ new to programming, but isn't it possible to create a public variable for the colors which you can edit in an editor or setting menu?

@meteyou
Copy link
Member

meteyou commented Mar 6, 2023

All interface settings are the same function like this. It's only more work, than just a switch. You have to restyle all charts and other functions for the light mode.

@Rigattoni
Copy link

Are there plans and may be an ETA for the light mode?
The dark mode is nice, but sometimes you really need some better contrast as it is given with the dark mode, at least if you are working outside and have a sunny day. Then it is quite hard to see the stuff.
Mostly the editor is not readable anymore. Yes, I can download the file to edit it in notepad ++... Easier to handle would be to have a white background and contrasting colors in the editor itself.

@meteyou
Copy link
Member

meteyou commented Jun 24, 2023

@Rigattoni this is just a hobby project. so we don't have any ETA...

light mode is planned, but there are much more important things i have to implement, before i can implement a light mode. I hoped, that a contributor will implement this missing feature before...

@meteyou meteyou added this to the vNext milestone Jun 24, 2023
@meteyou meteyou added the good first issue Simple task for new contributors label Jun 24, 2023
@meteyou
Copy link
Member

meteyou commented Jun 24, 2023

I added all missing tags and milestones. Maybe it is better visible now for contributors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Simple task for new contributors 💡 Type: FR Requests a new feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants