Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unusable Confirmation popup on Emergenct Stop #1549

Closed
pfgh1 opened this issue Sep 7, 2023 · 4 comments
Closed

Unusable Confirmation popup on Emergenct Stop #1549

pfgh1 opened this issue Sep 7, 2023 · 4 comments
Labels
⚡ Type: Bug Something isn't working

Comments

@pfgh1
Copy link

pfgh1 commented Sep 7, 2023

Mainsail Version:

2.7.1

Browser:

Chrome

Device:

Desktop PC

Operating System:

Windows

What happened?

When clicking on emergency stop a popup window launches asking for confirmation. However the action (emergency stop/firmware shutdown,) immediately occurs with the popup serving no function.

What did you expect to happen instead?

Either no prompt like in previous versions or have the prompt actually stall the operation until yes/no is clicked.

Really the best would probably be to add a configuration option to enable/disable the confirmation. Some people might find value in protection from accidentally clicking emergency stop whereas others might want emergency stop to be just that... immediate.

Thanks for the great work!

How to reproduce this bug?

Click Emergency Stop during a print job.

Additional information:

No response

@pfgh1 pfgh1 added the ⚡ Type: Bug Something isn't working label Sep 7, 2023
@meteyou
Copy link
Member

meteyou commented Sep 7, 2023

this is already fixed -> #1526

@meteyou meteyou closed this as completed Sep 7, 2023
@pfgh1
Copy link
Author

pfgh1 commented Sep 7, 2023

Thanks but I am on 2.7.1 and still get the popup?

@meteyou
Copy link
Member

meteyou commented Sep 7, 2023

Yes, because I fixed the issue after V2.7.1

@pfgh1
Copy link
Author

pfgh1 commented Sep 7, 2023

d0h sorry. Thanks again for the awesome work on this project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⚡ Type: Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants