Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Color Picker not displaying for PCA9632 with no pins specified #2022

Closed
dockterj opened this issue Oct 2, 2024 · 13 comments · Fixed by #2028
Closed

Color Picker not displaying for PCA9632 with no pins specified #2022

dockterj opened this issue Oct 2, 2024 · 13 comments · Fixed by #2028
Labels
⚡ Type: Bug Something isn't working
Milestone

Comments

@dockterj
Copy link

dockterj commented Oct 2, 2024

Mainsail Version:

2.12.0

Browser:

Edge

Device:

Laptop

Operating System:

Windows

What happened?

I have multi color LEDs connected to a PCA9632. This device is connected by I2C using all default values:
[pca9632 led] color_order: BGRW initial_BLUE: 1.0 initial_GREEN: 1.0 initial_RED: 1.0

This led shows up in Mainsail under miscellaneous, but I am only able to pick the blue channel.

What did you expect to happen instead?

Some kind of multi color picker should appear.

How to reproduce this bug?

From discord conversations it appears that not having pins specified is causing this device to not be recognized properly.

Additional information:

No response

@dockterj dockterj added the ⚡ Type: Bug Something isn't working label Oct 2, 2024
@meteyou meteyou added this to the v2.13.0 milestone Oct 2, 2024
@meteyou
Copy link
Member

meteyou commented Oct 15, 2024

hey @dockterj, pls upload a klippy.log

and pls share the output of:

http://<ip or hostname>/printer/objects/query?pca9632 led

@meteyou
Copy link
Member

meteyou commented Oct 15, 2024

you can also test the PR #2028 if you have time. I think the issue was, because PCA9632 doesnt return a array for the color order.

@dockterj
Copy link
Author

@meteyou thanks for this. I'll be home in a few days and will test as soon as I can.

@meteyou
Copy link
Member

meteyou commented Oct 15, 2024

@dockterj thank you very much! if you need "faster help", feel free to ping me on discord.

@dockterj
Copy link
Author

http://klipperbot.local/printer/objects/query?pca9632%20led

{
"result": {
"eventtime": 2353.670446115,
"status": {
"pca9632 led": {
"color_data": [
[
1,
1,
1,
0,
0
]
]
}
}
}
}

@dockterj
Copy link
Author

klippy (58).log

@dockterj
Copy link
Author

I tried changing the color order in printer.cfg and it appears that mainsail is picking the first color. Is this a bug in the PCA9632 implementation that it isn't returning the color order array?

@meteyou
Copy link
Member

meteyou commented Oct 17, 2024

pls post also the content from http://klipperbot.local/printer/objects/query?configfile=settings.

the status return is a little bit different then a neopixel return. neopixels return an array with the colorOrder, but the PCA9632 only return a string. you can also test the PR #2028 . there i already tried to fixed this issue.

can you pls explain which hardware do you use? maybe i can buy something like that to test this. maybe there is also an issue with the LED templates, but i cannot test it without the hardware.

@dockterj
Copy link
Author

query.json

@dockterj
Copy link
Author

I maintain a fork of Klipper to run on Makerbot Replicator 2 and 2X printers (and other clones that use type k thermocouples and ADS1118 for the hotend).

I'll test the PR you linked to - I don't have an environment set up yet for Mainsail development - I'm working on that right now.

@meteyou
Copy link
Member

meteyou commented Oct 19, 2024

@dockterj you can download a "prebuild" zip from the workflow. you don't have to set up a mainsail development

@dockterj
Copy link
Author

@meteyou Sorry I'm not familiar enough with Github to know where to get that from. Can you send me a link?

@meteyou
Copy link
Member

meteyou commented Oct 19, 2024

on this page in the "Artifacts" panel is a "mainsail-latest.zip": https://github.com/mainsail-crew/mainsail/actions/runs/11352773937?pr=2028

this is the build from the PR workflow. Just unzip it and upload it via SFTP to ~/mainsail (pls remove all files in this directory, before you upload the new files).

a force reload (SHIFT+CTRL+F5) will be also needed, to load the new files in your browser.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⚡ Type: Bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants