Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix multiple issues in the refactored update manager #1497

Merged
merged 4 commits into from
Jul 30, 2023
Merged

fix: fix multiple issues in the refactored update manager #1497

merged 4 commits into from
Jul 30, 2023

Conversation

meteyou
Copy link
Member

@meteyou meteyou commented Jul 29, 2023

Signed-off-by: Stefan Dej meteyou@gmail.com

Description

This PR fixes multiple issues in the update manager:

  • remove warnings from mainsail, because moonraker post the same one
  • add anomalies to each entry (if exists)
  • fix issues with wrong links to github pages
  • fix button text when the state is dirty

Related Tickets & Documents

none

Mobile & Desktop Screenshots/Recordings

image

[optional] Are there any post-deployment tasks we need to perform?

  • it would be nice to have a PR to moonraker to add more informations to the default corrupt, detached and dirty messages (like the old one before from mainsail)

@meteyou
refactor: remove notification texts
8401d21 
Signed-off-by: Stefan Dej <meteyou@gmail.com>
@meteyou
refactor: add anomalies
f140dbb 
Signed-off-by: Stefan Dej <meteyou@gmail.com>
@meteyou
refactor: WIP
288a9e0 
Signed-off-by: Stefan Dej <meteyou@gmail.com>
@meteyou
fix: fix issue with wrong repo_name in links to github
320c8f7 
Signed-off-by: Stefan Dej <meteyou@gmail.com>
@meteyou meteyou requested review from dw-0 and rackrick July 29, 2023 18:19
@github-actions
Copy link
Contributor

Language file analysis report:

File Missing Keys Unused Keys
cz.json 69 5
da.json 72 5
de.json 1 2
en.json 0 2
es.json 211 7
fr.json 73 5
hu.json 207 7
ja.json 71 5
ko.json 67 5
nl.json 73 5
pl.json 30 3
pt.json 44 4
ru.json 44 4
sv.json 327 7
tr.json 1 2
uk.json 186 7
zh.json 30 4
zh_TW.json 103 4

@meteyou meteyou merged commit 9eb133b into mainsail-crew:develop Jul 30, 2023
8 checks passed
@meteyou meteyou deleted the fix/update-manager-button-state branch July 30, 2023 19:02
Zeanon added a commit to LynxCrew/mainsail that referenced this pull request Jul 30, 2023
@Zeanon
Squashed commit of the following:
bf4458e 
commit 1b763e2
Merge: 4d241fc 1a12554
Author: Stefan Dej <meteyou@gmail.com>
Date:   Sun Jul 30 21:23:05 2023 +0200

    [Automated] Merged develop into target master

commit 1a12554
Author: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
Date:   Sun Jul 30 19:22:55 2023 +0000

    chore: push version number to v2.6.2

commit 7251a8c
Author: Zhu Qian <xiaoqianzi15@gmail.com>
Date:   Mon Jul 31 03:17:39 2023 +0800

    locale(zh): update chinese locale (mainsail-crew#1486)

    Co-authored-by: Stefan Dej <meteyou@gmail.com>

commit cda3098
Author: Stefan Dej <meteyou@gmail.com>
Date:   Sun Jul 30 21:03:00 2023 +0200

    fix: fix issue with cannot extrude after a Klipper restart (mainsail-crew#1495)

commit 9eb133b
Author: Stefan Dej <meteyou@gmail.com>
Date:   Sun Jul 30 21:02:28 2023 +0200

    fix: fix multiple issues in the refactored update manager (mainsail-crew#1497)

commit 6a4cca7
Author: Stefan Dej <meteyou@gmail.com>
Date:   Sun Jul 30 21:01:05 2023 +0200

    fix: fix issue with create/edit presets and refactor settings (mainsail-crew#1499)

commit d67ef3a
Author: Stefan Dej <meteyou@gmail.com>
Date:   Sun Jul 30 12:41:08 2023 +0200

    fix: use webcam name instead of UUID for timelapse plugin (mainsail-crew#1492)

commit aeee198
Author: Stefan Dej <meteyou@gmail.com>
Date:   Fri Jul 28 22:48:01 2023 +0200

    fix: fix issue with camel-case object names in temperature panel (mainsail-crew#1491)

commit 5c40820
Author: Stefan Dej <meteyou@gmail.com>
Date:   Thu Jul 27 23:02:51 2023 +0200

    fix: fix flip function in several webcam clients (mainsail-crew#1487)

commit e929c7c
Author: Stefan Dej <meteyou@gmail.com>
Date:   Thu Jul 27 09:42:07 2023 +0200

    fix: hide rpm in temperature_fans without tachometer_pin (mainsail-crew#1489)

commit 0b47a80
Author: Stefan Dej <meteyou@gmail.com>
Date:   Mon Jul 24 22:13:16 2023 +0200

    refactor: refactor SettingsRow (mainsail-crew#1484)

commit 8447be2
Author: Stefan Dej <meteyou@gmail.com>
Date:   Mon Jul 24 22:08:50 2023 +0200

    fix: fix editor save & restart button behavior (mainsail-crew#1483)

commit 0c5aca8
Author: Daviteusz <daviteusz0@gmail.com>
Date:   Mon Jul 24 19:27:21 2023 +0200

    locale(pl): Update Polish translation (mainsail-crew#1482)

commit eceb442
Author: meteyou <meteyou@users.noreply.github.com>
Date:   Mon Jul 24 07:36:14 2023 +0000

    docs(changelog): update changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rackrick rackrick rackrick approved these changes

@dw-0 dw-0 Awaiting requested review from dw-0

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@meteyou @rackrick