Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add option to disable favicon progress circle #1825

Merged

Conversation

meteyou
Copy link
Member

@meteyou meteyou commented Mar 20, 2024

Description

This PR adds a option to disable the progress circle as favicon during a print.

Related Tickets & Documents

fixes: #1754

Mobile & Desktop Screenshots/Recordings

none

[optional] Are there any post-deployment tasks we need to perform?

none

Signed-off-by: Stefan Dej <meteyou@gmail.com>
@meteyou meteyou requested review from dw-0 and rackrick March 20, 2024 18:55
Copy link
Contributor

Language file analysis report:

File Missing Keys Unused Keys
en.json 0 4

src/locales/en.json Outdated Show resolved Hide resolved
src/locales/en.json Outdated Show resolved Hide resolved
meteyou and others added 2 commits April 5, 2024 10:38
Co-authored-by: rackrick <45207681+rackrick@users.noreply.github.com>
Signed-off-by: Stefan Dej <meteyou@gmail.com>
Copy link
Contributor

github-actions bot commented Apr 5, 2024

Language file analysis report:

File Missing Keys Unused Keys
en.json 0 4

@meteyou meteyou merged commit 7583168 into mainsail-crew:develop Apr 5, 2024
1 check passed
@meteyou meteyou deleted the feat/disable-favicon-progress-circle branch April 5, 2024 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Settings option to disable favIcon progress circle
2 participants