feat: Add hotkeys tied to Save, Save + Restart #1902
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I left this as a draft because I can't seem to figure out why the save and restart is not working.
So it is like it is erroring, but also working? |
|
thx for this PR. i think i found your issue. if you press "save & restart", it also trigger the "save" command first. if you change the order from the shortcuts in the dialog, it works fine. |
|
@kevinkhill is there anything missing from your side for this PR? it looks good from to me. feel free to switch it to "ready to review". |
dosubot
bot
added
the
size:XS
meteyou
approved these changes
Jun 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I am trying to solve a personal issue of mine with this PR. I compulsively press ctrl+s while making changes in my editor, but this breaks my flow since it launches the save page dialog of the browser.
I propose overriding the default browser behavior for hotkeys with keybindings for our editor actions.
Changes:
Screenshots
I could try and make a screen recording of pressing the hotkeys but I didn't feel like it would add much to the PR