Skip to content

Commit c8fb973

Browse files
committed
MySQLTuner dont understand Thread Pool in Percona Server 5.7 #386
1 parent dab1e7e commit c8fb973

File tree

1 file changed

+2
-14
lines changed

1 file changed

+2
-14
lines changed

mysqltuner.pl

Lines changed: 2 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -3070,27 +3070,15 @@ sub mysql_stats {
30703070
}
30713071

30723072
# Thread cache
3073-
# if ( $myvar{'thread_cache_size'} eq 0 ) {
3074-
# badprint "Thread cache is disabled";
3075-
# push( @generalrec, "Set thread_cache_size to 4 as a starting value" );
3076-
# push( @adjvars, "thread_cache_size (start at 4)" );
3077-
# }
3078-
# else {
3079-
# if ( defined( $myvar{'thread_handling'} )
3080-
# and $myvar{'thread_handling'} eq 'pools-of-threads' )
3081-
# {
3082-
# infoprint "Thread cache hit rate: not used with pool-of-threads";
3083-
# }
3084-
30853073
if ( defined( $myvar{'thread_handling'} )
30863074
and $myvar{'thread_handling'} eq 'pool-of-threads' )
30873075
{
30883076
# https://www.percona.com/doc/percona-server/LATEST/performance/threadpool.html
30893077
# When thread pool is enabled, the value of the thread_cache_size variable
30903078
# is ignored. The Threads_cached status variable contains 0 in this case.
30913079
infoprint "Thread cache not used with thread_handling=pool-of-threads";
3092-
}
3093-
else {
3080+
}
3081+
else {
30943082
if ( $myvar{'thread_cache_size'} eq 0 ) {
30953083
badprint "Thread cache is disabled";
30963084
push( @generalrec, "Set thread_cache_size to 4 as a starting value" );

0 commit comments

Comments
 (0)