Upgrade laravel backup 9 + laravel 12

Author: rasmuscnielsen

.claude/settings.local.json

@@ -0,0 +1,9 @@
+{
+  "permissions": {
+    "allow": [
+      "Bash(./vendor/bin/phpunit --migrate-configuration)",
+      "Bash(./vendor/bin/phpunit --display-all-issues)"
+    ]
+  },
+  "enableAllProjectMcpServers": false
+}

.github/workflows/test.yml

@@ -2,16 +2,14 @@ name: Run tests
 
 on:
   push:
-  schedule:
-    - cron: '0 0 * * *'
 
 jobs:
   test:
     runs-on: ubuntu-latest
 
     services:
       mysql:
-        image: mysql:5.7
+        image: mysql:8.0
         env:
           MYSQL_DATABASE: laravel_backup_sql_check
           MYSQL_ROOT_PASSWORD: root
@@ -22,15 +20,15 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        php: [8.0,8.1]
-        laravel: [8.*,9.*]
-        dependency-version: [prefer-lowest,prefer-stable]
+        php: [8.2, 8.3, 8.4]
+        laravel: [10.*, 11.*, 12.*]
+        dependency-version: [prefer-lowest, prefer-stable]
 
     name: P${{ matrix.php }} - L${{ matrix.laravel }} - ${{ matrix.dependency-version }}
 
     steps:
       - name: Checkout code
-        uses: actions/checkout@v1
+        uses: actions/checkout@v4
 
       - name: Setup PHP
         uses: shivammathur/setup-php@v2

.gitignore

@@ -3,4 +3,5 @@ composer.phar
 composer.lock
 vendor
 .env
-.phpunit.result.cache
+.phpunit.result.cache
+.phpunit.cache

composer.json

@@ -2,15 +2,15 @@
     "name": "makeabledk/laravel-backup-sql-check",
     "license": "CC-BY-SA-4.0",
     "require": {
-        "php": "^8.0",
-        "symfony/process": "^5.0|^6.0"
+        "php": "^8.2",
+        "symfony/process": "^6.0|^7.0"
     },
     "require-dev": {
-        "spatie/laravel-backup": "^7.0|^8.0",
-        "laravel/laravel": "^8.6.10|^9.0",
-        "phpunit/phpunit": "^9.0",
-        "orchestra/testbench": "^6.0",
-        "mockery/mockery": "^1.5"
+        "spatie/laravel-backup": "^9.0",
+        "laravel/laravel": "^10.0|^11.0|^12.0",
+        "phpunit/phpunit": "^10.0|^11.0",
+        "orchestra/testbench": "^8.0|^9.0|^10.0",
+        "mockery/mockery": "^1.6"
     },
     "autoload": {
         "psr-4": {

phpunit.xml

@@ -1,10 +1,5 @@
 <?xml version="1.0" encoding="UTF-8"?>
-<phpunit xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" backupGlobals="false" backupStaticAttributes="false" bootstrap="vendor/autoload.php" colors="true" convertErrorsToExceptions="true" convertNoticesToExceptions="true" convertWarningsToExceptions="true" processIsolation="false" stopOnFailure="false" xsi:noNamespaceSchemaLocation="https://schema.phpunit.de/9.3/phpunit.xsd">
-  <coverage>
-    <include>
-      <directory suffix=".php">src/</directory>
-    </include>
-  </coverage>
+<phpunit xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" backupGlobals="false" bootstrap="vendor/autoload.php" colors="true" processIsolation="false" stopOnFailure="false" xsi:noNamespaceSchemaLocation="https://schema.phpunit.de/11.5/phpunit.xsd" cacheDirectory=".phpunit.cache" backupStaticProperties="false">
   <testsuites>
     <testsuite name="Package Test Suite">
       <directory suffix="Test.php">./tests/</directory>
@@ -13,4 +8,9 @@
   <php>
     <ini name="display_errors" value="1"/>
   </php>
+  <source>
+    <include>
+      <directory suffix=".php">src/</directory>
+    </include>
+  </source>
 </phpunit>

src/HealthySqlDump.php

@@ -36,7 +36,7 @@ public function __construct(float $timeout = 60)
      * @throws \Spatie\Backup\Exceptions\InvalidHealthCheck
      * @throws \Throwable
      */
-    public function checkHealth(BackupDestination $backupDestination)
+    public function checkHealth(BackupDestination $backupDestination): void
     {
         $this->failsOnEmpty($newestBackup = $backupDestination->backups()->newest());
 

tests/Feature/HealthySqlDumpTest.php

@@ -9,6 +9,7 @@
 use Makeable\SqlCheck\DiskSpace;
 use Makeable\SqlCheck\HealthySqlDump;
 use Makeable\SqlCheck\Tests\TestCase;
+use PHPUnit\Framework\Attributes\Test;
 use Spatie\Backup\Events\HealthyBackupWasFound;
 use Spatie\Backup\Events\UnhealthyBackupWasFound;
 
@@ -29,51 +30,47 @@ public function setUp(): void
         ]);
     }
 
-    /** @test */
+    #[Test]
     public function it_succeeds_when_file_is_healthy()
     {
         Event::fake(HealthyBackupWasFound::class);
         Event::listen(UnhealthyBackupWasFound::class, function ($event) {
             throw $event->backupDestinationStatus->getHealthCheckFailure()->exception();
         });
 
-        $this->artisan('backup:monitor')->assertExitCode(0);
-
+        $exitCode = Artisan::call('backup:monitor');
+        $this->assertEquals(0, $exitCode);
         Event::assertDispatched(HealthyBackupWasFound::class);
     }
 
-    /** @test */
+    #[Test]
     public function it_fails_when_backup_is_corrupt()
     {
         config()->set('backup.monitor_backups.0.name', 'unhealthy');
 
         Event::fake();
 
         Artisan::call('backup:monitor');
-
+        $this->assertStringContainsString('are considered unhealthy!', Artisan::output());
         Event::assertDispatched(UnhealthyBackupWasFound::class);
-
-        $this->assertStringContainsString('unhealthy!', Artisan::output());
     }
 
-    /** @test */
+    #[Test]
     public function it_fails_when_sql_process_exceed_the_timeout_limit()
     {
         config()->set('backup.monitor_backups.0.health_checks', [HealthySqlDump::class => 0.01]);
 
         Event::fake(UnhealthyBackupWasFound::class);
 
         Artisan::call('backup:monitor');
-
+        $this->assertStringContainsString('are considered unhealthy!', Artisan::output());
         Event::assertDispatched(UnhealthyBackupWasFound::class);
 
-        $this->assertStringContainsString('unhealthy!', Artisan::output());
-
         // Manually remove database, because error exited code before deleting it
-        DB::select('DROP DATABASE `healthy-sql-dump--backup--mysite-2019-09-16-08-00-07`');
+        DB::statement('DROP DATABASE `healthy-sql-dump--backup--mysite-2019-09-16-08-00-07`');
     }
 
-    /** @test */
+    #[Test]
     public function it_fails_on_insufficient_disk_space()
     {
         app()->bind(DiskSpace::class, function () {

tests/TestCase.php

@@ -9,7 +9,7 @@
 class TestCase extends Orchestra
 {
     /**
-     * @param  \Illuminate\Foundation\Application  $app
+     * @param      \Illuminate\Foundation\Application  $app
      * @return array
      */
     protected function getPackageProviders($app)
@@ -25,6 +25,7 @@ protected function getEnvironmentSetUp($app)
         $app->useEnvironmentPath(__DIR__.'/..');
         $app->bootstrapWith([LoadEnvironmentVariables::class]);
 
+        config()->set('database.default', 'mysql');
         config()->set('database.connections.mysql.host', env('DB_HOST'));
         config()->set('database.connections.mysql.username', env('DB_USERNAME'));
         config()->set('database.connections.mysql.password', env('DB_PASSWORD'));